svn commit: r1181605 - /hbase/branches/0.89/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java

[ns...@apache.org]

Author: nspiegelberg
Date: Tue Oct 11 02:25:13 2011
New Revision: 1181605

URL: http://svn.apache.org/viewvc?rev=1181605&view=rev
Log:
Fix test which sets invalid timestamp for KeyValues.

Summary:
A few unit tests in TestFromClientSide.java used to generated
the timestamp for a KV using random.nextLong(), this can return negative
values as well. Hence, this would create a scenario where there would be
expired KV's in the StoreFiles.

Test Plan: 1) Rerun tests
Reviewed By: kannan
Reviewers: kannan
Commenters: nspiegelberg
CC: , hbase@lists, kannan, nspiegelberg, pritam
Revert Plan:
Tags:

- begin *PUBLIC* platform impact section -
Bugzilla: #
- end platform impact -

Differential Revision: 282163

Modified:
    hbase/branches/0.89/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java

Modified: hbase/branches/0.89/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java?rev=1181605&r1=1181604&r2=1181605&view=diff
==============================================================================
--- hbase/branches/0.89/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java (original)
+++ hbase/branches/0.89/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java Tue Oct 11 02:25:13 2011
@@ -3918,9 +3918,8 @@ public class TestFromClientSide {
     Put put = new Put(row);
     for(int i = 0; i < nPuts; i++) {
       byte[] qualifier = Bytes.toBytes(random.nextInt());
-      Long timestamp = random.nextLong();
       byte[] value = Bytes.toBytes(random.nextInt());
-      put.add(family, qualifier, timestamp, value);
+      put.add(family, qualifier, value);
     }
     table.put(put);
   }