You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Bruno P. Kinoshita" <br...@yahoo.com.br> on 2012/04/09 06:57:30 UTC
[functor] Distribute tests from TestAlgorithms into several test
classes under algorithm test package
Hi all,
The test class o.a.c.functor.TestAlgorithms contains tests for several
algorithms (Retain Matching, Remove Matching, Predicated Loop, among
others), and it is not using generics.
I think it would be simpler to have the tests created as
o.a.c.functor.algorithm.<TestAlgorithm>. This way, one test class would
be responsible for one algorithm, it would have less methods, and be
easier to understand.
If there is no objection, I would like to create a patch with the test
classes under o.a.c.functor.algorithm, with one test for each algorithm
and using generics.
Any thoughts on this?
Thank you in advance!
--
Bruno P. Kinoshita
http://www.kinoshita.eti.br
http://www.tupilabs.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [functor] Distribute tests from TestAlgorithms into several test
classes under algorithm test package
Posted by "Bruno P. Kinoshita" <br...@yahoo.com.br>.
Sure thing Matt. Issue created:
https://issues.apache.org/jira/browse/FUNCTOR-15, I will attach the
patch there.
Many thanks.
On 04/09/2012 02:43 AM, Matt Benson wrote:
> Sounds good, Bruno. Can you file/attach in JIRA?
>
> Matt
>
> On Sun, Apr 8, 2012 at 11:57 PM, Bruno P. Kinoshita
> <br...@yahoo.com.br> wrote:
>> Hi all,
>>
>> The test class o.a.c.functor.TestAlgorithms contains tests for several
>> algorithms (Retain Matching, Remove Matching, Predicated Loop, among
>> others), and it is not using generics.
>>
>> I think it would be simpler to have the tests created as
>> o.a.c.functor.algorithm.<TestAlgorithm>. This way, one test class would be
>> responsible for one algorithm, it would have less methods, and be easier to
>> understand.
>>
>> If there is no objection, I would like to create a patch with the test
>> classes under o.a.c.functor.algorithm, with one test for each algorithm and
>> using generics.
>>
>> Any thoughts on this?
>>
>> Thank you in advance!
>> --
>> Bruno P. Kinoshita
>> http://www.kinoshita.eti.br
>> http://www.tupilabs.com
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
--
Bruno P. Kinoshita
http://www.kinoshita.eti.br
http://www.tupilabs.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [functor] Distribute tests from TestAlgorithms into several test
classes under algorithm test package
Posted by Matt Benson <gu...@gmail.com>.
Sounds good, Bruno. Can you file/attach in JIRA?
Matt
On Sun, Apr 8, 2012 at 11:57 PM, Bruno P. Kinoshita
<br...@yahoo.com.br> wrote:
> Hi all,
>
> The test class o.a.c.functor.TestAlgorithms contains tests for several
> algorithms (Retain Matching, Remove Matching, Predicated Loop, among
> others), and it is not using generics.
>
> I think it would be simpler to have the tests created as
> o.a.c.functor.algorithm.<TestAlgorithm>. This way, one test class would be
> responsible for one algorithm, it would have less methods, and be easier to
> understand.
>
> If there is no objection, I would like to create a patch with the test
> classes under o.a.c.functor.algorithm, with one test for each algorithm and
> using generics.
>
> Any thoughts on this?
>
> Thank you in advance!
> --
> Bruno P. Kinoshita
> http://www.kinoshita.eti.br
> http://www.tupilabs.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org