You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/11 08:10:07 UTC
[GitHub] [skywalking] mrproliu opened a new pull request #4490: Fix GraphQL
profile queried error when cannot matches any snapshot
mrproliu opened a new pull request #4490: Fix GraphQL profile queried error when cannot matches any snapshot
URL: https://github.com/apache/skywalking/pull/4490
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- GraphQL query profile analyzation without matches any snapshot. Use ArrayList to return trees. Not using `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] mrproliu commented on a change in pull request #4490:
Fix GraphQL profile queried error when cannot matches any snapshot
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #4490: Fix GraphQL profile queried error when cannot matches any snapshot
URL: https://github.com/apache/skywalking/pull/4490#discussion_r390807805
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileAnalyzer.java
##########
@@ -88,7 +88,7 @@ public ProfileAnalyzation analyze(String segmentId, List<ProfileAnalyzeTimeRange
}).flatMap(Collection::stream).map(ProfileStack::deserialize).distinct().collect(Collectors.toList());
// analyze
- analyzation.setTrees(analyze(stacks));
+ analyzation.getTrees().addAll(analyze(stacks));
Review comment:
My fault. I will add an `if` judge before `addAll`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4490:
Fix GraphQL profile queried error when cannot matches any snapshot
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4490: Fix GraphQL profile queried error when cannot matches any snapshot
URL: https://github.com/apache/skywalking/pull/4490#discussion_r390802338
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileAnalyzer.java
##########
@@ -88,7 +88,7 @@ public ProfileAnalyzation analyze(String segmentId, List<ProfileAnalyzeTimeRange
}).flatMap(Collection::stream).map(ProfileStack::deserialize).distinct().collect(Collectors.toList());
// analyze
- analyzation.setTrees(analyze(stacks));
+ analyzation.getTrees().addAll(analyze(stacks));
Review comment:
What is the difference? `addAll(null)` will cause a NPE from my understanding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4490: Fix GraphQL
profile queried error when cannot matches any snapshot
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4490: Fix GraphQL profile queried error when cannot matches any snapshot
URL: https://github.com/apache/skywalking/pull/4490
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4490: Fix GraphQL
profile queried error when cannot matches any snapshot
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4490: Fix GraphQL profile queried error when cannot matches any snapshot
URL: https://github.com/apache/skywalking/pull/4490#issuecomment-597578617
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4490?src=pr&el=h1) Report
> Merging [#4490](https://codecov.io/gh/apache/skywalking/pull/4490?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/39489ebc1ef304e6896edb2a2059d0e6373e62a0?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/4490?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4490 +/- ##
==========================================
- Coverage 25.54% 25.52% -0.02%
==========================================
Files 1243 1244 +1
Lines 28837 28842 +5
Branches 3943 3944 +1
==========================================
- Hits 7367 7363 -4
- Misses 20793 20800 +7
- Partials 677 679 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4490?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...p/server/core/query/entity/ProfileAnalyzation.java](https://codecov.io/gh/apache/skywalking/pull/4490/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvZW50aXR5L1Byb2ZpbGVBbmFseXphdGlvbi5qYXZh) | `100% <100%> (ø)` | |
| [...p/server/core/profile/analyze/ProfileAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4490/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVBbmFseXplci5qYXZh) | `67.85% <66.66%> (-0.67%)` | :arrow_down: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4490/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `0% <0%> (-100%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4490/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `55% <0%> (-1.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4490?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4490?src=pr&el=footer). Last update [39489eb...5420854](https://codecov.io/gh/apache/skywalking/pull/4490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services