[GitHub] [spark] LuciferYang commented on a change in pull request #35847: [SPARK-38547][CORE] Use more generic `Channel` Interface to initialize Netty `BootStrap`

[GitBox <gi...@apache.org>]

LuciferYang commented on a change in pull request #35847:
URL: https://github.com/apache/spark/pull/35847#discussion_r825895179



##########
File path: common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java
##########
@@ -85,7 +84,7 @@
   private final Random rand;
   private final int numConnectionsPerPeer;
 
-  private final Class<? extends Channel> socketChannelClass;
+  private final Class<? extends Channel> channelClass;

Review comment:
       This rename is also to stop emphasizing `Socket`
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org