[GitHub] [bookkeeper] poorbarcode commented on a change in pull request #3133: [feature] [distributedlog] Add a api for delete empty zookeeper node

[GitBox <gi...@apache.org>]

poorbarcode commented on a change in pull request #3133:
URL: https://github.com/apache/bookkeeper/pull/3133#discussion_r836018365



##########
File path: stream/distributedlog/core/src/main/java/org/apache/distributedlog/impl/metadata/ZKLogStreamMetadataStore.java
##########
@@ -680,6 +680,40 @@ public void processResult(int rc, String path, Object ctx) {
         return promise;
     }
 
+    @Override
+    public CompletableFuture<Boolean> deleteLogUnRecursive(URI uri, final String logName) {

Review comment:
       > the distributed log will create a lot of metadata paths under the log, you can check the getLog method. Looks like the deleteLogUnRecursive will fail because we only delete the log path?
   
   ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org