You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fory.apache.org by "esafak (via GitHub)" <gi...@apache.org> on 2025/07/15 15:40:06 UTC
[PR] feat: Replace cloudpickle with native Fory serialization [fory]
esafak opened a new pull request, #2417:
URL: https://github.com/apache/fory/pull/2417
## What does this PR do?
* Removed cloudpickle dependency and related logic.
* Replaced cloudpickle serialization with Fory's native serialization for unsupported types.
* Updated serializers for Python arrays, NumPy arrays, and Objects to use native serialization.
* Modified tests to reflect the removal of cloudpickle and use of native serialization.
* Added global helper functions for testing to avoid issues with local function serialization.
* Updated README.md with a note about bazel caching issues.
## Related issues
Contributes to #2409
## Notes
Next `PickleSerializer` will be removed bit by bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] feat: Replace cloudpickle with native Fory serialization [fory]
Posted by "esafak (via GitHub)" <gi...@apache.org>.
esafak commented on PR #2417:
URL: https://github.com/apache/fory/pull/2417#issuecomment-3074366959
@chaokunyang I did not realize the xlang tests were being skipped in Python. I set `ENABLE_CROSS_LANGUAGE_TESTS` and now pytest complained that `fixture 'data_file_path' not found` is missing. I could not find a definition for it now or in the past. How is it supposed to work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] feat: Replace cloudpickle with native Fory serialization [fory]
Posted by "esafak (via GitHub)" <gi...@apache.org>.
esafak commented on PR #2417:
URL: https://github.com/apache/fory/pull/2417#issuecomment-3074871784
I think a comment the python xlang tests explain this would have helped, along with documentation of how to run them locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] feat: Replace cloudpickle with native Fory serialization [fory]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #2417:
URL: https://github.com/apache/fory/pull/2417#issuecomment-3311727064
> I'm busy, so feel free to take over.
I implemented in https://github.com/apache/fory/pull/2629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] feat: Replace cloudpickle with native Fory serialization [fory]
Posted by "esafak (via GitHub)" <gi...@apache.org>.
esafak commented on PR #2417:
URL: https://github.com/apache/fory/pull/2417#issuecomment-3275825150
I'm busy, so feel free to take over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] feat: Replace cloudpickle with native Fory serialization [fory]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #2417:
URL: https://github.com/apache/fory/pull/2417#issuecomment-3275779595
Hi @esafak , wil you continue working on this? I did a benchmark several days before. It shows that pyfory is faster than cpickle and has smaller size compared to pickle for [data in cpython benchmark](https://github.com/python/pyperformance/blob/main/pyperformance/data-files/benchmarks/bm_pickle/run_benchmark.py) . If we can drop-in replace pickle, it would be very promising.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] feat: Replace cloudpickle with native Fory serialization [fory]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #2417:
URL: https://github.com/apache/fory/pull/2417#issuecomment-3074487435
It's called from java CrossLanguageTest.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] feat: Replace cloudpickle with native Fory serialization [fory]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang closed pull request #2417: feat: Replace cloudpickle with native Fory serialization
URL: https://github.com/apache/fory/pull/2417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] feat: Replace cloudpickle with native Fory serialization [fory]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #2417:
URL: https://github.com/apache/fory/pull/2417#issuecomment-3076809624
> I think a comment the python xlang tests explain this would have helped, along with documentation of how to run them locally.
Add a comment in https://github.com/apache/fory/pull/2420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org