You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Ash Berlin-Taylor (JIRA)" <ji...@apache.org> on 2018/10/12 08:39:00 UTC
[jira] [Updated] (AIRFLOW-3089) Google auth doesn't work under http
[ https://issues.apache.org/jira/browse/AIRFLOW-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ash Berlin-Taylor updated AIRFLOW-3089:
---------------------------------------
Fix Version/s: 1.10.1
> Google auth doesn't work under http
> -----------------------------------
>
> Key: AIRFLOW-3089
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3089
> Project: Apache Airflow
> Issue Type: Bug
> Components: authentication
> Affects Versions: 1.10.0
> Reporter: Josh Carp
> Assignee: Josh Carp
> Priority: Minor
> Fix For: 2.0.0, 1.10.1
>
>
> The google auth backend hard-codes the https scheme into its redirect urls and so doesn't work with http. This happens because the redirect url sets the `_scheme` parameter to `https`. I I see that this change was made to allow google auth to work when airflow is run behind a proxy, but I think this fix isn't correct. Instead, proxies should be configured to set `X-Forwarded-Proto` to `https`, and Flask will set the scheme correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)