You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/05/19 12:35:41 UTC

[GitHub] flink pull request #3949: [FLINK-6629] Use HAServices to find connecting add...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/3949

    [FLINK-6629] Use HAServices to find connecting address for ClusterClient's ActorSystem

    The ClusterClient starts its ActorSystem lazily. In order to find out the address
    to which to bind, the ClusterClient tries to connect to the JobManager. In order
    to find out the JobManager's address it is important to use the
    HighAvailabilityServices instead of retrieving the address information from the
    configuration, because otherwise it conflicts with HA mode.
    
    cc @rmetzger.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixClusterClient

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3949.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3949
    
----
commit 6c77c336f402936d684497dc5f707fb713e52c7e
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-05-19T10:01:51Z

    [FLINK-6635] [test] Fix ClientConnectionTest
    
    The ClientConnectionTest passed even though it was failing the test because we
    were expecting an exception and checking a special word to contained in the
    exception's message. Unfortunately, we generated an AssertionError with the same
    word if the actual logic we wanted to test failed. That cause the test to pass.

commit b75eef9532b033b49b9a192597ccaec101203447
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-05-19T12:31:19Z

    [FLINK-6629] Use HAServices to find connecting address for ClusterClient's ActorSystem
    
    The ClusterClient starts its ActorSystem lazily. In order to find out the address
    to which to bind, the ClusterClient tries to connect to the JobManager. In order
    to find out the JobManager's address it is important to use the
    HighAvailabilityServices instead of retrieving the address information from the
    configuration, because otherwise it conflicts with HA mode.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3949: [FLINK-6629] Use HAServices to find connecting address fo...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3949
  
    Thanks for the review @rmetzger. Merging this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3949: [FLINK-6629] Use HAServices to find connecting add...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3949


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3949: [FLINK-6629] Use HAServices to find connecting address fo...

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/3949
  
    +1 to merge this change


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---