You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "arvindKandpal-ksolves (via GitHub)" <gi...@apache.org> on 2026/06/03 11:04:27 UTC
[PR] CASSANDRA-21425: Fix skipped tests and typos in CassandraRoleManagerTest [cassandra]
arvindKandpal-ksolves opened a new pull request, #4857:
URL: https://github.com/apache/cassandra/pull/4857
Fix skipped tests (missing @ Test) and typos in CassandraRoleManagerTest
**Context & Changes:**
While reviewing `CassandraRoleManagerTest.java`, I noticed a few minor issues that this patch addresses to improve test coverage and code consistency:
* **Enabled skipped tests**: Added missing `@Test` annotations to `testPasswordUpdateRateLimiting()` and `testPasswordUpdateRateLimitingDisabled()`, which were previously being silently skipped by JUnit.
* **Fixed typos and inconsistencies**:
* Corrected a typo in an inline comment (`role_b3` -> `role_b_3`).
* Removed an inconsistent trailing space in the `OverloadedException` assertion message (`"100ms. "` -> `"100ms."`) so it correctly matches the system's actual exception string.
* Fixed grammar in a comment (`primitive` -> `primitives`).
**Testing:**
* Ran the newly enabled tests locally using `ant test -Dtest.name=CassandraRoleManagerTest`.
* Verified that both tests now execute and pass successfully.
patch by Arvind Kandpal; reviewed by TBD for CASSANDRA-21425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-21425 / CASSANDRA-21262: Fix skipped tests, typos, and flaky test in CassandraRoleManagerTest [cassandra]
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic closed pull request #4857: CASSANDRA-21425 / CASSANDRA-21262: Fix skipped tests, typos, and flaky test in CassandraRoleManagerTest
URL: https://github.com/apache/cassandra/pull/4857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org