You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/19 09:59:30 UTC

[GitHub] GJL commented on issue #6668: [hotfix] Clear YarnTestBase

GJL commented on issue #6668: [hotfix] Clear YarnTestBase
URL: https://github.com/apache/flink/pull/6668#issuecomment-422737147
 
 
   Thank you for your contribution to Apache Flink @TisonKun.
   
   I understand that some things are not optimal, e.g., the static method
   `populateYarnSecureConfigurations` inside of `YarnTestBase.java`.
   
   I still would like to _not_ merge this change because the changes go beyond a
   _"hotfix"_:
   
   * It is difficult to track what you have changed.
   * The _"correct"_ order of methods, static classes, etc. inside a file is subjective.
   * You did not only re-order code; there are also small refactorings.
   * Your changes bury the original Git commit history.
   
   If you think some of your changes are important, you can create several less
   invasive PRs. Please close this PR if you agree, or let me know what you
   think.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services