You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by scottyaslan <gi...@git.apache.org> on 2016/12/06 22:24:42 UTC
[GitHub] nifi pull request #1305: [NIFI-3154] display ellipsis when text is sufficien...
GitHub user scottyaslan opened a pull request:
https://github.com/apache/nifi/pull/1305
[NIFI-3154] display ellipsis when text is sufficiently long in connec\u2026
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
\u2026tion details and connection configuration dialogs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scottyaslan/nifi NIFI-3154
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1305.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1305
----
commit 4840b6249e41769b75304cd12d50a92ff8b4ac40
Author: Scott Aslan <sc...@gmail.com>
Date: 2016-12-06T22:21:01Z
[NIFI-3154] display ellipsis when text is sufficiently long in connection details and connection configuration dialogs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1305: [NIFI-3154] display ellipsis when text is sufficiently lon...
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/1305
This PR addresses the long processor name/type, input/output port, and funnel values in the 'Connection Configuration' and 'Connection Details" dialogs. It adds ellipsis to the 'From <source>' and the 'To <destination>' text values for each type of <source> and <destination> types but leaves the 'Within Group' values as non-ellipsis since having really long names there does not make the dialog unreadable. @moranr Please take a look and let me know if you have any other suggestions. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1305: [NIFI-3154] display ellipsis when text is sufficiently lon...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1305
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1305: [NIFI-3154] display ellipsis when text is sufficien...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1305
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1305: [NIFI-3154] display ellipsis when text is sufficiently lon...
Posted by moranr <gi...@git.apache.org>.
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/1305
@scottyaslan this looks good. I put in a few long names in various cases and it is behaving as you describe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1305: [NIFI-3154] display ellipsis when text is sufficien...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1305#discussion_r91519524
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-connection-configuration.js ---
@@ -189,7 +189,7 @@ nf.ConnectionConfiguration = (function () {
// populate the port information
$('#input-port-source').show();
- $('#input-port-source-name').text(inputPortName);
+ $('#input-port-source-name').text(inputPortName).addClass('ellipsis').attr('title', inputPortName);
--- End diff --
Can the ellipsis class for all fields changed in this file be applied directly to the element in the corresponding JSP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---