You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by YorkShen <gi...@git.apache.org> on 2017/06/05 07:48:21 UTC
[GitHub] incubator-weex pull request #420: * [android] Use pair in android.util.pair.
GitHub user YorkShen opened a pull request:
https://github.com/apache/incubator-weex/pull/420
* [android] Use pair in android.util.pair.
As support-v4 actually supports api 9 from support library [24.2.0 and higher](https://developer.android.com/topic/libraries/support-library/index.html#api-versions). Any class reference in v4 library that is expected to work lower than API 9 and higher than API 4 should be [migrated](https://developer.android.com/topic/libraries/support-library/rev-archive.html).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YorkShen/incubator-weex android-feature-v4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/420.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #420
----
commit c75a5e2133ec5aafb8e6a9e12ba6f882c571d6c0
Author: YorkShen <sh...@gmail.com>
Date: 2017-06-05T07:47:09Z
* [android] Use pair in android.util.pair.
As support-v4 actually supports api 9 from support library [24.2.0 and higher](https://developer.android.com/topic/libraries/support-library/index.html#api-versions). Any class reference in v4 library that is expected to work lower than API 9 and higher than API 4 should be [migrate](https://developer.android.com/topic/libraries/support-library/rev-archive.html).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #420: * [android] Use pair in android.util.pair.
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/420
<!--
1 failure: Running your Dang...
0 warning:
1 markdown notices
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>Running your Dangerfile has Failed</td>
</tr>
</tbody>
</table>
## Danger has errored
Error: TypeError
```sh
TypeError: diff.match is not a function
at Object.<anonymous> (dangerfile.js:109:24)
at Runtime._execModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:447:13)
at Runtime.requireModule (/home/travis/build/apache/incubator-weex/node_modules/jest-runtime/build/index.js:295:14)
at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:136:33
at ensureCleanDangerfile (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:176:5)
at Object.<anonymous> (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:135:21)
at step (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:32:23)
at Object.next (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:13:53)
at /home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:7:71
at __awaiter (/home/travis/build/apache/incubator-weex/node_modules/danger/distribution/runner/DangerfileRunner.js:3:12)
```
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #420: * [android] Use pair in android.util.pair.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/420
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---