[GitHub] [activemq-artemis] wy96f commented on a change in pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached

[GitBox <gi...@apache.org>]

wy96f commented on a change in pull request #2785: ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is reached
URL: https://github.com/apache/activemq-artemis/pull/2785#discussion_r314566358
 
 

 ##########
 File path: artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQExceptionType.java
 ##########
 @@ -261,6 +261,12 @@ public ActiveMQException createException(String msg) {
       public ActiveMQException createException(String msg) {
          return new ActiveMQReplicationTimeooutException(msg);
       }
+   },
+   RESOURCE_LIMIT_REACHED(221) {
 
 Review comment:
   For older client that don't understand, "ActiveMQException"(type code is GENERIC_EXCEPTION) would be decoded and thrown. There are two places where ActiveMQExceptionType.SESSION_CREATION_REJECTED is judged, one is ActiveMQSessionContext::recreateSession(), the other is BridgeImpl::connect(). For both of them, the logic is same in the case of GENERIC_EXCEPTION(old client) and RESOURCE_LIMIT_EXCEEDED(new client).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services