You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2017/08/21 19:46:52 UTC
Review Request 61791: Raised the logging level of some (health) check
messages.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61791/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
Bugs: MESOS-7861
https://issues.apache.org/jira/browse/MESOS-7861
Repository: mesos
Description
-------
Some users pointed out that always logging the result of (health)
checks makes debugging problems easier.
Diffs
-----
src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e
Diff: https://reviews.apache.org/r/61791/diff/1/
Testing
-------
`make tests` on GNU/Linux
Thanks,
Gastón Kleiman
Re: Review Request 61791: Raised the logging level of some (health)
check messages.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61791/#review183376
-----------------------------------------------------------
Bad patch!
Reviews applied: [61791, 61766, 61697]
Failed command: python support/apply-reviews.py -n -r 61697
Error:
Traceback (most recent call last):
File "support/apply-reviews.py", line 417, in <module>
main()
File "support/apply-reviews.py", line 412, in main
reviewboard(options)
File "support/apply-reviews.py", line 402, in reviewboard
apply_review(options)
File "support/apply-reviews.py", line 160, in apply_review
commit_patch(options)
File "support/apply-reviews.py", line 268, in commit_patch
shell(cmd, options['dry_run'])
File "support/apply-reviews.py", line 144, in shell
error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True)
File "C:\Python27\lib\subprocess.py", line 168, in call
return Popen(*popenargs, **kwargs).wait()
File "C:\Python27\lib\subprocess.py", line 390, in __init__
errread, errwrite)
File "C:\Python27\lib\subprocess.py", line 610, in _execute_child
args = '{} /c "{}"'.format (comspec, args)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 25: ordinal not in range(128)
Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/260/console
- Mesos Reviewbot Windows
On Aug. 21, 2017, 12:46 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61791/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 12:46 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7861
> https://issues.apache.org/jira/browse/MESOS-7861
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some users pointed out that always logging the result of (health)
> checks makes debugging problems easier.
>
>
> Diffs
> -----
>
> src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e
>
>
> Diff: https://reviews.apache.org/r/61791/diff/1/
>
>
> Testing
> -------
>
> `make tests` on GNU/Linux
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 61791: Raised the logging level of some (health)
check messages.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61791/#review183402
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Aug. 21, 2017, 7:46 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61791/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 7:46 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7861
> https://issues.apache.org/jira/browse/MESOS-7861
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some users pointed out that always logging the result of (health)
> checks makes debugging problems easier.
>
>
> Diffs
> -----
>
> src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e
>
>
> Diff: https://reviews.apache.org/r/61791/diff/1/
>
>
> Testing
> -------
>
> `make tests` on GNU/Linux
>
>
> Thanks,
>
> Gastón Kleiman
>
>