You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Aaron T. Myers (JIRA)" <ji...@apache.org> on 2011/06/17 20:47:47 UTC

[jira] [Created] (HADOOP-7402) TestConfiguration doesn't clean up after itself

TestConfiguration doesn't clean up after itself
-----------------------------------------------

                 Key: HADOOP-7402
                 URL: https://issues.apache.org/jira/browse/HADOOP-7402
             Project: Hadoop Common
          Issue Type: Bug
          Components: test
    Affects Versions: 0.23.0
            Reporter: Aaron T. Myers
            Assignee: Aaron T. Myers
            Priority: Trivial
             Fix For: 0.23.0
         Attachments: hadoop-7402.0.patch

{{testGetFile}} and {{testGetLocalPath}} both create directories a, b, and c in the working directory from where the tests are run. They should clean up after themselves.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7402) TestConfiguration doesn't clean up after itself

Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051253#comment-13051253 ] 

Alejandro Abdelnur commented on HADOOP-7402:
--------------------------------------------


Those test dirs should be written in the build directory, not to pollute the source tree. 

Using the Java Sys prop 'test.build.data' as the base for those dirs would do.

Thxs.


> TestConfiguration doesn't clean up after itself
> -----------------------------------------------
>
>                 Key: HADOOP-7402
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7402
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7402.0.patch
>
>
> {{testGetFile}} and {{testGetLocalPath}} both create directories a, b, and c in the working directory from where the tests are run. They should clean up after themselves.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7402) TestConfiguration doesn't clean up after itself

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052131#comment-13052131 ] 

Hudson commented on HADOOP-7402:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #661 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/661/])
    

> TestConfiguration doesn't clean up after itself
> -----------------------------------------------
>
>                 Key: HADOOP-7402
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7402
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7402.0.patch, hadoop-7402.1.patch
>
>
> {{testGetFile}} and {{testGetLocalPath}} both create directories a, b, and c in the working directory from where the tests are run. They should clean up after themselves.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7402) TestConfiguration doesn't clean up after itself

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051276#comment-13051276 ] 

Hadoop QA commented on HADOOP-7402:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12482974/hadoop-7402.1.patch
  against trunk revision 1136249.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/648//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/648//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/648//console

This message is automatically generated.

> TestConfiguration doesn't clean up after itself
> -----------------------------------------------
>
>                 Key: HADOOP-7402
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7402
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7402.0.patch, hadoop-7402.1.patch
>
>
> {{testGetFile}} and {{testGetLocalPath}} both create directories a, b, and c in the working directory from where the tests are run. They should clean up after themselves.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7402) TestConfiguration doesn't clean up after itself

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HADOOP-7402:
-----------------------------------

    Status: Patch Available  (was: Open)

> TestConfiguration doesn't clean up after itself
> -----------------------------------------------
>
>                 Key: HADOOP-7402
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7402
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7402.0.patch, hadoop-7402.1.patch
>
>
> {{testGetFile}} and {{testGetLocalPath}} both create directories a, b, and c in the working directory from where the tests are run. They should clean up after themselves.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7402) TestConfiguration doesn't clean up after itself

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057098#comment-13057098 ] 

Hudson commented on HADOOP-7402:
--------------------------------

Integrated in Hadoop-Common-trunk-maven #43 (See [https://builds.apache.org/job/Hadoop-Common-trunk-maven/43/])
    

> TestConfiguration doesn't clean up after itself
> -----------------------------------------------
>
>                 Key: HADOOP-7402
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7402
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7402.0.patch, hadoop-7402.1.patch
>
>
> {{testGetFile}} and {{testGetLocalPath}} both create directories a, b, and c in the working directory from where the tests are run. They should clean up after themselves.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7402) TestConfiguration doesn't clean up after itself

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HADOOP-7402:
-----------------------------------

    Attachment: hadoop-7402.0.patch

Patch which fixes the issue. I manually verified that the created directories are cleaned up after a run of this test.

> TestConfiguration doesn't clean up after itself
> -----------------------------------------------
>
>                 Key: HADOOP-7402
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7402
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7402.0.patch
>
>
> {{testGetFile}} and {{testGetLocalPath}} both create directories a, b, and c in the working directory from where the tests are run. They should clean up after themselves.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7402) TestConfiguration doesn't clean up after itself

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051250#comment-13051250 ] 

Todd Lipcon commented on HADOOP-7402:
-------------------------------------

Rather than doing that, why not fix the test so that it chdirs into the build directory first? Or sets the conf to point to the build dir?

> TestConfiguration doesn't clean up after itself
> -----------------------------------------------
>
>                 Key: HADOOP-7402
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7402
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7402.0.patch
>
>
> {{testGetFile}} and {{testGetLocalPath}} both create directories a, b, and c in the working directory from where the tests are run. They should clean up after themselves.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7402) TestConfiguration doesn't clean up after itself

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HADOOP-7402:
-----------------------------------

    Attachment: hadoop-7402.1.patch

Patch which uses "test.build.data" as a prefix for the directories.

> TestConfiguration doesn't clean up after itself
> -----------------------------------------------
>
>                 Key: HADOOP-7402
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7402
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7402.0.patch, hadoop-7402.1.patch
>
>
> {{testGetFile}} and {{testGetLocalPath}} both create directories a, b, and c in the working directory from where the tests are run. They should clean up after themselves.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7402) TestConfiguration doesn't clean up after itself

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051377#comment-13051377 ] 

Eli Collins commented on HADOOP-7402:
-------------------------------------

+1

> TestConfiguration doesn't clean up after itself
> -----------------------------------------------
>
>                 Key: HADOOP-7402
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7402
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7402.0.patch, hadoop-7402.1.patch
>
>
> {{testGetFile}} and {{testGetLocalPath}} both create directories a, b, and c in the working directory from where the tests are run. They should clean up after themselves.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-7402) TestConfiguration doesn't clean up after itself

Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HADOOP-7402:
--------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I've committed this. Thanks atm!

> TestConfiguration doesn't clean up after itself
> -----------------------------------------------
>
>                 Key: HADOOP-7402
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7402
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7402.0.patch, hadoop-7402.1.patch
>
>
> {{testGetFile}} and {{testGetLocalPath}} both create directories a, b, and c in the working directory from where the tests are run. They should clean up after themselves.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-7402) TestConfiguration doesn't clean up after itself

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057159#comment-13057159 ] 

Hudson commented on HADOOP-7402:
--------------------------------

Integrated in Hadoop-Common-trunk #732 (See [https://builds.apache.org/job/Hadoop-Common-trunk/732/])
    

> TestConfiguration doesn't clean up after itself
> -----------------------------------------------
>
>                 Key: HADOOP-7402
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7402
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>            Priority: Trivial
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7402.0.patch, hadoop-7402.1.patch
>
>
> {{testGetFile}} and {{testGetLocalPath}} both create directories a, b, and c in the working directory from where the tests are run. They should clean up after themselves.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira