You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "nillehammer (JIRA)" <ji...@apache.org> on 2011/06/11 17:44:58 UTC
[jira] [Created] (TAP5-1545) Submit component should be able to
render as button type="submit"
Submit component should be able to render as button type="submit"
-----------------------------------------------------------------
Key: TAP5-1545
URL: https://issues.apache.org/jira/browse/TAP5-1545
Project: Tapestry 5
Issue Type: Improvement
Components: tapestry-core
Affects Versions: 5.2.5
Reporter: nillehammer
Priority: Minor
The Submit component renders an <input type="submit">. Since Html 4.0 it is possible to markup the submit button as what it is, a button. The HTML markup is <button type="submit">. I prefer this approach, because it makes styling easier. One could use a general CSS-styling for input-Elements (e.g. common width, special fonts etc.). And the submit button won't be affected.
To make this change backwards compatible, an optional parameter could be used in org.apache.tapestry5.corelib.components.Submit. The code:
@Parameter(value="false", defaultPrefix = BindingConstants.LITERAL)
private boolean renderAsButton;
And in the method beginRende()r:
if (renderAsButton) {
writer.element("button",
"type", "submit",
"name", name,
"id", clientId);
if (image !=null) {
writer.element("img", "src", image.toClientURL());
writer.end();
}
}
else {
//... do the usual rentering of input type submit
}
Thanks in advance and cheers to the commiters,
nillehammer
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1545) Submit component should be able to
render as button type="submit"
Posted by "Serge Eby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475639#comment-13475639 ]
Serge Eby commented on TAP5-1545:
---------------------------------
This would be handy, especially with the introduction of Twitter bootstrap in 5.4
> Submit component should be able to render as button type="submit"
> -----------------------------------------------------------------
>
> Key: TAP5-1545
> URL: https://issues.apache.org/jira/browse/TAP5-1545
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: nillehammer
> Priority: Minor
>
> The Submit component renders an <input type="submit">. Since Html 4.0 it is possible to markup the submit button as what it is, a button. The HTML markup is <button type="submit">. I prefer this approach, because it makes styling easier. One could use a general CSS-styling for input-Elements (e.g. common width, special fonts etc.). And the submit button won't be affected.
> To make this change backwards compatible, an optional parameter could be used in org.apache.tapestry5.corelib.components.Submit. The code:
> @Parameter(value="false", defaultPrefix = BindingConstants.LITERAL)
> private boolean renderAsButton;
> And in the method beginRende()r:
> if (renderAsButton) {
> writer.element("button",
> "type", "submit",
> "name", name,
> "id", clientId);
> if (image !=null) {
> writer.element("img", "src", image.toClientURL());
> writer.end();
> }
> }
> else {
> //... do the usual rentering of input type submit
> }
> Thanks in advance and cheers to the commiters,
> nillehammer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1545) Submit component should be able to
render as button type="submit"
Posted by "Serge Eby (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475639#comment-13475639 ]
Serge Eby commented on TAP5-1545:
---------------------------------
This would be handy, especially with the introduction of Twitter bootstrap in 5.4
> Submit component should be able to render as button type="submit"
> -----------------------------------------------------------------
>
> Key: TAP5-1545
> URL: https://issues.apache.org/jira/browse/TAP5-1545
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.2
> Reporter: nillehammer
> Priority: Minor
>
> The Submit component renders an <input type="submit">. Since Html 4.0 it is possible to markup the submit button as what it is, a button. The HTML markup is <button type="submit">. I prefer this approach, because it makes styling easier. One could use a general CSS-styling for input-Elements (e.g. common width, special fonts etc.). And the submit button won't be affected.
> To make this change backwards compatible, an optional parameter could be used in org.apache.tapestry5.corelib.components.Submit. The code:
> @Parameter(value="false", defaultPrefix = BindingConstants.LITERAL)
> private boolean renderAsButton;
> And in the method beginRende()r:
> if (renderAsButton) {
> writer.element("button",
> "type", "submit",
> "name", name,
> "id", clientId);
> if (image !=null) {
> writer.element("img", "src", image.toClientURL());
> writer.end();
> }
> }
> else {
> //... do the usual rentering of input type submit
> }
> Thanks in advance and cheers to the commiters,
> nillehammer
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira