[jira] [Commented] (SAMZA-349) add timer in metrics

["Yan Fang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076802#comment-14076802 ] 

Yan Fang commented on SAMZA-349:
--------------------------------

As discussed, it's better to create a Timer to monitor the spending time of a block of code, instead of refreshing the metrics every 60 seconds.

> add timer in metrics
> --------------------
>
>                 Key: SAMZA-349
>                 URL: https://issues.apache.org/jira/browse/SAMZA-349
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Yan Fang
>            Assignee: Yan Fang
>         Attachments: SAMZA-349.1.patch, SAMZA-349.patch
>
>
> If my understanding is correct, the metrics we provide are for every 60 seconds and all counters will be reset every 60 seconds. Current the MetricsSnapshotReporter seems missing this implementation. It sends out the metrics every 60 seconds but does not reset the counter value.
> {code}
>  registry.getGroup(group).foreach {
>           case (name, metric) =>
>             metric.visit(new MetricsVisitor {
>               def counter(counter: Counter) = groupMsg.put(name, counter.getCount: java.lang.Long)
>               def gauge[T](gauge: Gauge[T]) = groupMsg.put(name, gauge.getValue.asInstanceOf[Object])
>             })
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)