You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/12/04 01:40:57 UTC
Review Request 64274: Added `lambda::partial` to .
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64274/
-----------------------------------------------------------
Review request for mesos and Dmitry Zhuk.
Bugs: MESOS-6972
https://issues.apache.org/jira/browse/MESOS-6972
Repository: mesos
Description
-------
Added `lambda::partial` to <stout/lambda.hpp>.
Diffs
-----
3rdparty/stout/include/stout/lambda.hpp a61d97b69e7eebd057c94148d39c6e1fc3066017
3rdparty/stout/tests/lambda_tests.cpp ad8c2efddb6b64184670d0cfb33188ef843351ab
Diff: https://reviews.apache.org/r/64274/diff/1/
Testing
-------
Thanks,
Michael Park
Re: Review Request 64274: Added `lambda::partial` to
.
Posted by Dmitry Zhuk <dz...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64274/#review192718
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
3rdparty/stout/include/stout/lambda.hpp
Lines 162 (patched)
<https://reviews.apache.org/r/64274/#comment270972>
2 blank linkes befor and after?
3rdparty/stout/include/stout/lambda.hpp
Lines 172 (patched)
<https://reviews.apache.org/r/64274/#comment270967>
{ should be on the next line
3rdparty/stout/include/stout/lambda.hpp
Lines 181 (patched)
<https://reviews.apache.org/r/64274/#comment270968>
ditto
3rdparty/stout/include/stout/lambda.hpp
Line 159 (original), 289 (patched)
<https://reviews.apache.org/r/64274/#comment270970>
2 blank lines?
- Dmitry Zhuk
On Dec. 4, 2017, 3:21 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64274/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2017, 3:21 p.m.)
>
>
> Review request for mesos and Dmitry Zhuk.
>
>
> Bugs: MESOS-6972
> https://issues.apache.org/jira/browse/MESOS-6972
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `lambda::partial` to <stout/lambda.hpp>.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/lambda.hpp a61d97b69e7eebd057c94148d39c6e1fc3066017
> 3rdparty/stout/tests/lambda_tests.cpp ad8c2efddb6b64184670d0cfb33188ef843351ab
>
>
> Diff: https://reviews.apache.org/r/64274/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 64274: Added `lambda::partial` to
.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64274/
-----------------------------------------------------------
(Updated Dec. 4, 2017, 7:21 a.m.)
Review request for mesos and Dmitry Zhuk.
Changes
-------
Rebased.
Bugs: MESOS-6972
https://issues.apache.org/jira/browse/MESOS-6972
Repository: mesos
Description
-------
Added `lambda::partial` to <stout/lambda.hpp>.
Diffs (updated)
-----
3rdparty/stout/include/stout/lambda.hpp a61d97b69e7eebd057c94148d39c6e1fc3066017
3rdparty/stout/tests/lambda_tests.cpp ad8c2efddb6b64184670d0cfb33188ef843351ab
Diff: https://reviews.apache.org/r/64274/diff/2/
Changes: https://reviews.apache.org/r/64274/diff/1-2/
Testing
-------
Thanks,
Michael Park