You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by rj...@apache.org on 2014/02/21 02:27:40 UTC

svn commit: r1570412 - in /bloodhound/trunk/bloodhound_theme/bhtheme: htdocs/bloodhound.css templates/bh_ticket.html templates/bh_ticket_actions.html

Author: rjollos
Date: Fri Feb 21 01:27:40 2014
New Revision: 1570412

URL: http://svn.apache.org/r1570412
Log:
0.8dev: Change the help tips to icons in the Ticket action form. Refs #710.

Previously this change was implemented on the ticket form using !Javascript. It is not implemented on the batch modify form as well. The line height of items on the batch modify form has also been set in order to improve the vertical arrangement.

Modified:
    bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css
    bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html
    bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket_actions.html

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css
URL: http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css?rev=1570412&r1=1570411&r2=1570412&view=diff
==============================================================================
--- bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css (original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/htdocs/bloodhound.css Fri Feb 21 01:27:40 2014
@@ -1384,3 +1384,5 @@ input[type="radio"]:not(:checked) + labe
  width: 32%;
 }
 /* @end */
+
+#batchmod_action { line-height: 2.75em }

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html
URL: http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html?rev=1570412&r1=1570411&r2=1570412&view=diff
==============================================================================
--- bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html (original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket.html Fri Feb 21 01:27:40 2014
@@ -210,13 +210,6 @@
               action_input_trigger.blur(action_click);
               if (action_trigger.attr('checked'))
                 action_click();
-
-              var action_help = action_ui.find('.help-block').detach()
-                  .text().replace(/\s+/g, ' ').replace(/^ Tip /g, 'Tip: ')
-                  .replace(/^\s$/, '');
-              if (action_help)
-                  $('<i class="icon-info-sign"></i>').appendTo(action_ui)
-                      .attr('title', action_help);
             });
           }
 

Modified: bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket_actions.html
URL: http://svn.apache.org/viewvc/bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket_actions.html?rev=1570412&r1=1570411&r2=1570412&view=diff
==============================================================================
--- bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket_actions.html (original)
+++ bloodhound/trunk/bloodhound_theme/bhtheme/templates/bh_ticket_actions.html Fri Feb 21 01:27:40 2014
@@ -24,18 +24,11 @@
       xmlns:xi="http://www.w3.org/2001/XInclude"
       py:strip="">
   <div py:for="key, label, controls, hints in action_controls">
-      <input type="radio" id="action_$key" name="action" value="$key"
-             checked="${key == action or None}" />
-      <label for="action_$key">$label</label>
-      $controls
-      <div class="help-block" py:if="hints">
-        <p py:for="idx, hint in 
-            enumerate(h for h in hints if h.strip())">
-          <span class="label label-info"
-              py:if="idx == 0">Tip</span>
-          $hint
-        </p>
-      </div>
+    <input type="radio" id="action_$key" name="action" value="$key"
+           checked="${key == action or None}" />
+    <label for="action_$key">$label</label>
+    $controls
+    <i py:if="hints" class="icon-info-sign" title="${'\n'.join(h for h in hints if h.strip())}"></i>
   </div>
 </html>