You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2015/03/31 10:20:57 UTC
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/5288
[SPARK-6629] cancelJobGroup() may not work for jobs whose job groups are inherited from parent threads
When a job is submitted with a job group and that job group is inherited from a parent thread, there are multiple bugs that may prevent this job from being cancelable via `SparkContext.cancelJobGroup()`:
- When filtering jobs based on their job group properties, DAGScheduler calls `get()` instead of `getProperty()`, which does not respect inheritance, so it will skip over jobs whose job group properties were inherited.
- `Properties` objects are mutable, but we do not make defensive copies / snapshots, so modifications of the parent thread's job group will cause running jobs' groups to change; this also breaks cancelation.
Both of these issues are easy to fix: use `getProperty()` and perform defensive copying.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark localProperties-mutability-race
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5288
----
commit b376114a333f4a1d3b2153f75b14856c9ba72875
Author: Josh Rosen <jo...@databricks.com>
Date: 2015-03-31T08:00:54Z
Fix bug that prevented jobs with inherited job group properties from being cancelled.
commit 707e4170c97aa38e529c457a6760b15e2e75e02b
Author: Josh Rosen <jo...@databricks.com>
Date: 2015-03-31T08:10:58Z
Clone local properties to prevent mutations from breaking job cancellation.
commit 3f7b9e83dc199d8ed772a7822ae4b012c888ca2a
Author: Josh Rosen <jo...@databricks.com>
Date: 2015-03-31T08:19:02Z
Add JIRA reference; move clone into DAGScheduler
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-87992846
[Test build #29471 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29471/consoleFull) for PR 5288 at commit [`3f7b9e8`](https://github.com/apache/spark/commit/3f7b9e83dc199d8ed772a7822ae4b012c888ca2a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-96286305
[Test build #706 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/706/consoleFull) for PR 5288 at commit [`9e29654`](https://github.com/apache/spark/commit/9e29654e066b4325ff7897725ea882376dc2603a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-91604024
> use getProperty() and perform defensive copying.
+1. It's possible that `SparkListener` will see some wrong key-values in `SparkListenerJobStart.properties` without the defensive copying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-87996678
On further reflection, this might not be a use-case that we want to support. I don't think we make any user-facing promises about how / whether these properties are inherited across threads and there are reasons why we may want to discourage this implicit inheritance in favor of explicitly setting the job group in each thread that submits jobs; see https://issues.apache.org/jira/browse/SPARK-4514 for a related discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-94223111
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30542/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-92579899
@JoshRosen, will this PR be merged? I'm using `localProperties` in #5473. If we don't copy `localProperties`, `SparkListenerJobStart.properties` will just point to `localProperties`. It will be used in `SparkListener`, which runs in another thread. If `localProperties` is changed before a listener uses `SparkListenerJobStart.properties`, the listener will see the modification rather than the properties when Job starts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5288#discussion_r27460149
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
@@ -675,7 +679,7 @@ class DAGScheduler(
// Cancel all jobs belonging to this job group.
// First finds all active jobs with this group id, and then kill stages for them.
val activeInGroup = activeJobs.filter(activeJob =>
- groupId == activeJob.properties.get(SparkContext.SPARK_JOB_GROUP_ID))
--- End diff --
This bug has been around since 2013!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-96288336
[Test build #707 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/707/consoleFull) for PR 5288 at commit [`9e29654`](https://github.com/apache/spark/commit/9e29654e066b4325ff7897725ea882376dc2603a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-88017102
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29471/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-94215493
[Test build #30540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30540/consoleFull) for PR 5288 at commit [`5d90750`](https://github.com/apache/spark/commit/5d907503f62f745052a69d9e302577c6c8315986).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-92590069
@zsxwing I haven't merged this yet because I had some doubts about how inheritance of local properties should work, especially when threads are re-used. Let me revisit this now, though, since I think the changes here seem to make the behavior more consistent. I'll also take a closer look at your use-case in #5473 to try to understand how it would be affected by this change and whether it's prone to any of the weird thread re-use corner cases that can crop up with localProperties.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-90405437
Hi @JoshRosen , sorry for late response, looks like I missed this notification. The reason why here changes to `InheritableThreadLocal` is that: we have such a scenario, we enabled FairScheduler in Spark with two groups, one group is running streaming program, and another group is running query, they separated in two threads and shared with same SparkContext, since streaming job is running in a threadpool when submitted to Spark DAGScheduler, so if we do not use `InheritableThreadLocal`, we cannot get the right value in child thread, so I changed to this way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5288
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-90406796
Hi @JoshRosen , I think this is the original PR (https://github.com/mesos/spark/pull/937). I'm not sure is this issue still existed, it is a quite old code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-94215466
[Test build #30540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30540/consoleFull) for PR 5288 at commit [`5d90750`](https://github.com/apache/spark/commit/5d907503f62f745052a69d9e302577c6c8315986).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-88006325
@jerryshao, since you added unit tests for `localProperty` inheritance in ffa5f8e, do you know of any actual use-cases that motivate this inheritance? As far as I can tell, we don't seem to rely on it internally inside of Spark and it's not documented in a user-facing way. Users can't be relying on it for job group cancellation, since this patch demonstrates that this has always been broken, and it seems unlikely that anyone would choose to use this for cross-thread communication: in order to read and write these properties, you need to have a reference to the SparkContext instance, at which point you might as well just pass the information directly instead of implicitly inheriting it across threads.
If there's no actual use for this inheritance, it might be nice to remove it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-96768903
[Test build #31033 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31033/consoleFull) for PR 5288 at commit [`9e29654`](https://github.com/apache/spark/commit/9e29654e066b4325ff7897725ea882376dc2603a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-97502084
@JoshRosen is it ready to go? At least, #5473 needs the defensive copy of Properties to avoid breaking tests. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-88017095
[Test build #29471 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29471/consoleFull) for PR 5288 at commit [`3f7b9e8`](https://github.com/apache/spark/commit/3f7b9e83dc199d8ed772a7822ae4b012c888ca2a).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-94525599
/cc @andrewor14, what do you think about this fix? The inheritance + cancellation tests here address an incredibly obscure corner-case that most users might not hit or expect to work (since I don't think that we ever explicitly state that job groups will be inherited across threads). The defensive copy of Properties seems like a good change by itself, though.
I'd like to try to get some closure on this issue by either deciding that we're going to support the inheritance feature as it was originally described or by removing this feature and instructing users to manually set job groups in child threads; at this point, I think that either option could work since the current behavior is broken. We could also decide to just leave the inheritance alone and only do the copying change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-94215494
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30540/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-97575256
Merging this. The defensive copying is blocker for #5473 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5288#discussion_r27460121
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
@@ -493,7 +495,8 @@ class DAGScheduler(
val func2 = func.asInstanceOf[(TaskContext, Iterator[_]) => _]
val waiter = new JobWaiter(this, jobId, partitions.size, resultHandler)
eventProcessLoop.post(JobSubmitted(
- jobId, rdd, func2, partitions.toArray, allowLocal, callSite, waiter, properties))
+ jobId, rdd, func2, partitions.toArray, allowLocal, callSite, waiter,
+ SerializationUtils.clone(properties)))
--- End diff --
We need to use `SerializationUtils.clone()` in order to perform a deep-clone which also captures properties that were inherited from parents; see 5a5526164bdf9ecf1306d4570e816eb4df5cfd2b for more discussion of this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-94215902
[Test build #30542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30542/consoleFull) for PR 5288 at commit [`9e29654`](https://github.com/apache/spark/commit/9e29654e066b4325ff7897725ea882376dc2603a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6629] cancelJobGroup() may not work for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5288#issuecomment-94223107
[Test build #30542 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30542/consoleFull) for PR 5288 at commit [`9e29654`](https://github.com/apache/spark/commit/9e29654e066b4325ff7897725ea882376dc2603a).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` case class Params(`
* `sealed abstract class Node extends Serializable `
* `sealed trait Split extends Serializable `
* `final class CategoricalSplit(`
* `final class ContinuousSplit(override val featureIndex: Int, val threshold: Double) extends Split `
* `trait DecisionTreeModel `
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org