You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kathey Marsden (JIRA)" <ji...@apache.org> on 2012/06/14 01:15:42 UTC
[jira] [Updated] (DERBY-5816) store.ServicePropertiesFileTest fails
on z/OS
[ https://issues.apache.org/jira/browse/DERBY-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kathey Marsden updated DERBY-5816:
----------------------------------
Attachment: DERBY-5816_diff.txt
ATtached is a patch for this issue. I think that there is a product issue as well as a test issue. The new marker at the the end of service.properties should have been written out in US-ASCII to match the encoding of the rest of the service.properties file that was written with Propoerties.store().
Please review. I think/hope the issue with the wrong encoding for the end of file marker is not a regression from 10.8, but just means that the fix for DERBY-5283 won't work on z/os in 10.9.
Note: In order to test encoding sensitive changes on Windows you can run with -Dfile.encoding="UTF-16"
> store.ServicePropertiesFileTest fails on z/OS
> ---------------------------------------------
>
> Key: DERBY-5816
> URL: https://issues.apache.org/jira/browse/DERBY-5816
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.9.1.0
> Environment: z/os
> java version "1.7.0"
> Java(TM) SE Runtime Environment (build pmz6470-20110827_01)
> IBM J9 VM (build 2.6, JRE 1.7.0 z/OS s390x-64 20110810_88604 (JIT enabled, AOT enabled)
> J9VM - R26_Java726_GA_20110810_1208_B88592
> JIT - r11_20110810_20466
> GC - R26_Java726_GA_20110810_1208_B88592
> J9CL - 20110810_88604)
> JCL - 20110809_01 based on Oracle 7b147
> $
> Reporter: Kathey Marsden
> Attachments: DERBY-5816_diff.txt
>
>
> store.ServicePropertiesFileTest fails on z/OS with two failures below. Looks like likely test encoding issue
> 1) testSevicePropertiesFileWithBackup(org.apache.derbyTesting.functionTests.tests.store.ServicePropertiesFileTest)junit.
> framework.AssertionFailedError
> at org.apache.derbyTesting.functionTests.tests.store.ServicePropertiesFileTest.assertEOFToken(ServicePropertiesF
> ileTest.java:275)
> at org.apache.derbyTesting.functionTests.tests.store.ServicePropertiesFileTest.testSevicePropertiesFileWithBacku
> p(ServicePropertiesFileTest.java:178)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:88)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:55)
> at org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:113)
> at org.apache.derbyTesting.junit.BaseJDBCTestCase.runBareOverridable(BaseJDBCTestCase.java:424)
> at org.apache.derbyTesting.junit.BaseJDBCTestCase.runBare(BaseJDBCTestCase.java:441)
> at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
> at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
> at junit.extensions.TestSetup.run(TestSetup.java:25)
> at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
> at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
> at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
> at junit.extensions.TestSetup.run(TestSetup.java:25)
> 2) testSevicePropertiesFileCorruptedWithBackup(org.apache.derbyTesting.functionTests.tests.store.ServicePropertiesFileTe
> st)junit.framework.ComparisonFailure: expected:<[#--- last line, don't put anything after this line ---]> but was:<[{```
> @ @ k@ } @ @ @ @ @ @```ยง]>
> at org.apache.derbyTesting.functionTests.tests.store.ServicePropertiesFileTest.removeEOFToken(ServicePropertiesF
> ileTest.java:301)
> at org.apache.derbyTesting.functionTests.tests.store.ServicePropertiesFileTest.testSevicePropertiesFileCorrupted
> WithBackup(ServicePropertiesFileTest.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:88)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:55)
> at org.apache.derbyTesting.junit.BaseTestCase.runBare(BaseTestCase.java:113)
> at org.apache.derbyTesting.junit.BaseJDBCTestCase.runBareOverridable(BaseJDBCTestCase.java:424)
> at org.apache.derbyTesting.junit.BaseJDBCTestCase.runBare(BaseJDBCTestCase.java:441)
> at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
> at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
> at junit.extensions.TestSetup.run(TestSetup.java:25)
> at org.apache.derbyTesting.junit.BaseTestSetup.run(BaseTestSetup.java:57)
> at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
> at junit.extensions.TestSetup$1.protect(TestSetup.java:21)
> at junit.extensions.TestSetup.run(TestSetup.java:25)
> FAILURES!!!
> Tests run: 290, Failures: 2, Errors: 0
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira