[GitHub] [solr] cpoerschke commented on a diff in pull request #1880: fix not being able to stop a solr by port number

["cpoerschke (via GitHub)" <gi...@apache.org>]

cpoerschke commented on code in PR #1880:
URL: https://github.com/apache/solr/pull/1880#discussion_r1313306240


##########
solr/bin/solr:
##########
@@ -1301,6 +1301,7 @@ if [ $# -gt 0 ]; then
               exit 1
             fi
             SOLR_PORT="$2"
+            PROVIDED_SOLR_PORT=SOLR_PORT

Review Comment:
   Did you mean `${SOLR_PORT}` here instead?
   ```suggestion
               PROVIDED_SOLR_PORT="${SOLR_PORT}"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org