You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2015/06/17 12:11:11 UTC

git commit: updated refs/heads/master to eaa4eba

Repository: cloudstack
Updated Branches:
  refs/heads/master a2129b294 -> eaa4eba74


Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineHostVO.java Assert isn't used in prod runtime, null is checked in method

Signed-off-by: Daan Hoogland <da...@gmail.com>

This closes #448


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/eaa4eba7
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/eaa4eba7
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/eaa4eba7

Branch: refs/heads/master
Commit: eaa4eba74df75ff87fb755bc1ba5c982f8c49bee
Parents: a2129b2
Author: Rafael da Fonseca <rs...@gmail.com>
Authored: Sun Jun 14 21:30:54 2015 +0200
Committer: Daan Hoogland <da...@gmail.com>
Committed: Wed Jun 17 12:10:45 2015 +0200

----------------------------------------------------------------------
 .../cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java   | 2 --
 1 file changed, 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/eaa4eba7/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java
----------------------------------------------------------------------
diff --git a/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java b/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java
index b064a35..efa34df 100644
--- a/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java
+++ b/engine/orchestration/src/org/apache/cloudstack/engine/datacenter/entity/api/db/EngineHostVO.java
@@ -296,8 +296,6 @@ public class EngineHostVO implements EngineHost, Identity {
     }
 
     public String getDetail(String name) {
-        assert (details != null) : "Did you forget to load the details?";
-
         return details != null ? details.get(name) : null;
     }