[GitHub] [incubator-ratis] runzhiwang commented on a change in pull request #272: RATIS-1130. Add E2E test for Ratis streaming based on MiniRaftCluster

[GitBox <gi...@apache.org>]

runzhiwang commented on a change in pull request #272:
URL: https://github.com/apache/incubator-ratis/pull/272#discussion_r521878967



##########
File path: ratis-netty/src/test/java/org/apache/ratis/netty/MiniRaftClusterWithNetty.java
##########
@@ -47,6 +48,20 @@ public MiniRaftClusterWithNetty newCluster(String[] ids, RaftProperties prop) {
     }
   }
 
+  public interface FactoryGetWithDataStreamEnabled extends Factory.Get<MiniRaftClusterWithNetty> {

Review comment:
       try the following code, and delete `FactoryGetWithDataStreamEnabled`.
   ```
   public class TestDataStreamWithNetty extends DataStreamTests<MiniRaftClusterWithNetty>
       implements MiniRaftClusterWithNetty.FactoryGet {
     {
       RaftConfigKeys.DataStream.setType(getProperties(), SupportedDataStreamType.NETTY);
     }
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org