You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "Karl Richter (JIRA)" <ji...@apache.org> on 2015/09/16 13:24:46 UTC
[jira] [Updated] (STORM-1048) Add generic type to conf arugment of ISpout.open

     [ https://issues.apache.org/jira/browse/STORM-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karl Richter updated STORM-1048:
--------------------------------
    Description: 
Changing the signature of `ISpout.open` from `void open(Map conf, TopologyContext context, SpoutOutputCollector collector)` to `void open(Map<Object,Object> conf, TopologyContext context, SpoutOutputCollector collector)` would allow, but not force callers to write warning-free code. The change should be backwards compatible because callers can ignore it like storm currently does in the `ISpout` interface.

The changes would only avoid compiler warnings about unchecked conversations and rawtypes. It would make the code longer and there'd be no functional change as `Map` defaults to `Map<Object, Object>` after type erasure.

Alternatively a generic type for the key and the value of `conf` could be introduced in `ISpout`.

I volunteer to do it in the complete source.

  was:
Changing the signature of `ISpout.open` from `void open(Map conf, TopologyContext context, SpoutOutputCollector collector)` to `void open(Map<Object,Object> conf, TopologyContext context, SpoutOutputCollector collector)` would allow, but not force callers to write typesafe code. The change should be backwards compatible because callers can ignore it like storm currently does in the `ISpout` interface.

I volunteer to do it in the complete source.


> Add generic type to conf arugment of ISpout.open
> ------------------------------------------------
>
>                 Key: STORM-1048
>                 URL: https://issues.apache.org/jira/browse/STORM-1048
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 0.10.0
>            Reporter: Karl Richter
>
> Changing the signature of `ISpout.open` from `void open(Map conf, TopologyContext context, SpoutOutputCollector collector)` to `void open(Map<Object,Object> conf, TopologyContext context, SpoutOutputCollector collector)` would allow, but not force callers to write warning-free code. The change should be backwards compatible because callers can ignore it like storm currently does in the `ISpout` interface.
> The changes would only avoid compiler warnings about unchecked conversations and rawtypes. It would make the code longer and there'd be no functional change as `Map` defaults to `Map<Object, Object>` after type erasure.
> Alternatively a generic type for the key and the value of `conf` could be introduced in `ISpout`.
> I volunteer to do it in the complete source.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)