[jira] [Commented] (MESOS-2637) Consolidate 'foo', 'bar', ... string constants in test and example code

["Colin Williams (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547960#comment-14547960 ] 

Colin Williams commented on MESOS-2637:
---------------------------------------

When you say that they should be consolidated, are you referring to extracting the value into a string in the same test or pulling all of the duplicate label creation/checking into a function?

> Consolidate 'foo', 'bar', ... string constants in test and example code
> -----------------------------------------------------------------------
>
>                 Key: MESOS-2637
>                 URL: https://issues.apache.org/jira/browse/MESOS-2637
>             Project: Mesos
>          Issue Type: Bug
>          Components: technical debt
>            Reporter: Niklas Quarfot Nielsen
>            Assignee: Colin Williams
>
> We are using 'foo', 'bar', ... string constants and pairs in src/tests/master_tests.cpp, src/tests/slave_tests.cpp, src/tests/hook_tests.cpp and src/examples/test_hook_module.cpp for label and hooks tests. We should consolidate them to make the call sites less prone to forgetting to update all call sites.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)