[GitHub] [tvm] echuraev commented on a change in pull request #8054: [METAL] Fix codegen for inf and erf

[GitBox <gi...@apache.org>]

echuraev commented on a change in pull request #8054:
URL: https://github.com/apache/tvm/pull/8054#discussion_r633581589



##########
File path: src/target/source/codegen_metal.h
##########
@@ -51,12 +51,13 @@ class CodeGenMetal final : public CodeGenC {
   void PrintVecElemStore(const std::string& vec, DataType t, int i, const std::string& value) final;
   // overload visitor
   void VisitExpr_(const BroadcastNode* op, std::ostream& os) final;  // NOLINT(*)
-  // overload visitor
   void VisitExpr_(const CallNode* op, std::ostream& os) final;  // NOLINT(*)
+  void VisitExpr_(const FloatImmNode* op, std::ostream& os) final;
   // reuse parent's function.
   using CodeGenC::PrintType;
 
  private:
+  friend void PrintConst(const FloatImmNode* op, std::ostream& os, CodeGenMetal* p);

Review comment:
       It was a copy-paste :) Thank you. Fixed. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org