You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mridulm <gi...@git.apache.org> on 2017/02/07 19:44:08 UTC

[GitHub] spark issue #16697: [SPARK-19358][CORE] LiveListenerBus shall log the event ...

Github user mridulm commented on the issue:

    https://github.com/apache/spark/pull/16697
  
    Instead of keeping track of the history of dropped events, which will become expensive very fast, how about logging the current event (if dropped) when we log at [#L146][https://github.com/apache/spark/blob/6ee28423ad1b2e6089b82af64a31d77d3552bb38/core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala#L146]
    There can be a logTrace line at line [133][https://github.com/apache/spark/blob/6ee28423ad1b2e6089b82af64a31d77d3552bb38/core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala#L133] if you do want to log all dropped events.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org