You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Pinti0001 (via GitHub)" <gi...@apache.org> on 2024/02/21 13:48:50 UTC
[I] Fix checkstyle reported warning in many files [shardingsphere]
Pinti0001 opened a new issue, #30236:
URL: https://github.com/apache/shardingsphere/issues/30236
## WARNING:
File name : AlterDefaultShadowAlgorithmStatementAssert.java
- Utility classes should not have a public or default constructor. (35:1) [HideUtilityClassConstructor]
File name : AlterIndexStatementAssert.java
- Utility classes should not have a public or default constructor. (39:1) [HideUtilityClassConstructor]
And many more
**It's generally a good practice to follow the advice provided by Checkstyle and other static analysis tools, as they help enforce best practices and maintain code quality**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Fix checkstyle reported warning in many files [shardingsphere]
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian closed issue #30236: Fix checkstyle reported warning in many files
URL: https://github.com/apache/shardingsphere/issues/30236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Fix checkstyle reported warning in many files [shardingsphere]
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on issue #30236:
URL: https://github.com/apache/shardingsphere/issues/30236#issuecomment-1956804858
- I'm not sure where these Logs come from, everything is fine with Checkstyle's CI. You can notice the related CI Log at https://github.com/apache/shardingsphere/actions/workflows/required-check.yml .
- If you think there is room for optimization with project current checkstyle and spotless config, you need to open a PR. Refer to https://github.com/apache/shardingsphere/tree/master/src/resources .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Fix checkstyle reported warning in many files [shardingsphere]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #30236:
URL: https://github.com/apache/shardingsphere/issues/30236#issuecomment-2015822663
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Fix checkstyle reported warning in many files [shardingsphere]
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on issue #30236:
URL: https://github.com/apache/shardingsphere/issues/30236#issuecomment-2015853074
- Closing issue due to lack of responses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org