You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/09 19:01:09 UTC
[GitHub] [airflow] potiuk opened a new pull request, #22880: Replaces old Breeze with Python based implementation
potiuk opened a new pull request, #22880:
URL: https://github.com/apache/airflow/pull/22880
Over the last few months together with Outreachy interns
we rewrote the most important functionality of the old Bash-based
Breeze with Python Based implementation.
We approached it in systematic way with capturing all our decisions
in the ADR format (dev/breeze/docs) and implementing the parts
that are used on a daily basis by the users. Breeze2 as it was
called is ready for Prime-Time with the users so we are swapping
out the old breeze wiht the new one.
The old `breeze` has been moved to `breeze-legacy` and we will
gradually parts of it that are already migrated to Python and proven
while continue rewriting the parts that are missing (mostly the
maintainer tools) and replacing the remaining CI shell scripts with
the new `breeze` commands.
This PR:
* moves `breeze` to `breeze-legacy`
* moves `Breezei2` to `breeze`
* updates documentation and screenshots where applicable
* explains old vs. new breeze in documentation
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22880: Replace old Breeze with Python based implementation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22880:
URL: https://github.com/apache/airflow/pull/22880#issuecomment-1094248372
I've also added protection to not add accidentally new top-level imports in breeze.py as they would break auto-complete and self-upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22880: Replace old Breeze with Python based implementation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22880:
URL: https://github.com/apache/airflow/pull/22880#issuecomment-1094345064
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22880: Replace old Breeze with Python based implementation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22880:
URL: https://github.com/apache/airflow/pull/22880#issuecomment-1094225809
Config now is more "obvious". It also prints summary of the config (@edithturn ):
<img width="581" alt="Screenshot 2022-04-10 at 11 11 36" src="https://user-images.githubusercontent.com/595491/162611201-8689f62e-b9d8-4a5f-8b3f-a88bfaa0164e.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22880: Replaces old Breeze with Python based implementation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22880:
URL: https://github.com/apache/airflow/pull/22880#issuecomment-1094191389
> * In `config`, I got no output or a warning saying that we set Python as a backend. (Maybe I don't understand exactly how is its behavior)
Good Point. We should give feedback to the user ! The idea is that when you set python version, next time you get that default python version when you do not specify any python version. I.e. .
`breeze` -> Python 3.7 used by default
`breeze config --python 3.8` -> python 3.8 set as default
`breeze` -> Python 3.8 used
> I also ran, start-airflow, and tmux session is being open on my VSC terminal, (this is so nice 👏🏼 ), my question is in the part of creating permissions (four windows). Am I doing something wrong to get that error? or I should do an extra step to have it configure it
The errors are unrelated - they are also with current breeze' start-airflow - I will raise that to others as we are very close to cutting 2.3 branch I think those errors need to be fixed before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22880: Replace old Breeze with Python based implementation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22880:
URL: https://github.com/apache/airflow/pull/22880#issuecomment-1094293742
Looks like Green and ready for Python's Breeze prime time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22880: Replaces old Breeze with Python based implementation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22880:
URL: https://github.com/apache/airflow/pull/22880#issuecomment-1094107517
cc: @Bowrna @edithturn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edithturn commented on pull request #22880: Replaces old Breeze with Python based implementation
Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #22880:
URL: https://github.com/apache/airflow/pull/22880#issuecomment-1094145656
@potiuk I ran it on my machine (Linux Ubuntu 20.10), wow works very nice! That part of the comments with a click is fantastic 🤩
I ran some commands like "config" and "start-airflow". My question is if all these options al already implemented.
* In `config`, I got no output or a warning saying that we set Python as a backend. (Maybe I don't understand exactly how is its behavior)
* I also ran, `start-airflow`, and **tmux** session is being open on my VSC terminal, (this is so nice 👏🏼 ), my question is in the part of creating permissions (four windows). Am I doing something wrong to get that error? or I should do an extra step to have it configure it
It is fantastic @potiuk and also is 💯 faster on my computer 👏🏼 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #22880: Replace old Breeze with Python based implementation
Posted by GitBox <gi...@apache.org>.
Bowrna commented on PR #22880:
URL: https://github.com/apache/airflow/pull/22880#issuecomment-1094258357
@potiuk this is amazing :) you have made this change very quickly 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edithturn commented on pull request #22880: Replace old Breeze with Python based implementation
Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #22880:
URL: https://github.com/apache/airflow/pull/22880#issuecomment-1094294842
Go ahead @potiuk, let us know! 🚀 💪🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22880: Replace old Breeze with Python based implementation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22880:
URL: https://github.com/apache/airflow/pull/22880#issuecomment-1094332745
Hwy @eladkal :). That's IT..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22880: Replaces old Breeze with Python based implementation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22880:
URL: https://github.com/apache/airflow/pull/22880#issuecomment-1094108007
Here it is.
Switching to Python based Breeze. FINALLY.
Note. I would like to drag your attention to this nicely generated screenshots in our Breeze documentation :) https://github.com/potiuk/airflow/blob/swap-old-breeze-with-new/BREEZE.rst#installation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22880: Replace old Breeze with Python based implementation
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #22880:
URL: https://github.com/apache/airflow/pull/22880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org