You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/06/11 03:27:11 UTC
[GitHub] [tomcat] rotty3000 opened a new pull request #296: Fix BZ 64514 - classes missing from bootstrap.jar
rotty3000 opened a new pull request #296:
URL: https://github.com/apache/tomcat/pull/296
Signed-off-by: Raymond Augé <ro...@apache.org>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on a change in pull request #296: Fix BZ 64514 - classes missing from bootstrap.jar
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on a change in pull request #296:
URL: https://github.com/apache/tomcat/pull/296#discussion_r438764896
##########
File path: build.xml
##########
@@ -375,6 +376,8 @@
<include name="org/apache/catalina/startup/Tool.*" />
<include name="org/apache/catalina/security/SecurityClassLoad.*" />
<include name="org/apache/catalina/webresources/war/**" />
+ <include name="org/apache/coyote/Constants.*" />
Review comment:
it is transitively required by `Globals.java`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #296: Fix BZ 64514 - classes missing from bootstrap.jar
Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #296:
URL: https://github.com/apache/tomcat/pull/296
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #296: Fix BZ 64514 - classes missing from bootstrap.jar
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #296:
URL: https://github.com/apache/tomcat/pull/296#issuecomment-644307300
Merged via the command line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on a change in pull request #296: Fix BZ 64514 - classes missing from bootstrap.jar
Posted by GitBox <gi...@apache.org>.
rmaucher commented on a change in pull request #296:
URL: https://github.com/apache/tomcat/pull/296#discussion_r438616279
##########
File path: build.xml
##########
@@ -375,6 +376,8 @@
<include name="org/apache/catalina/startup/Tool.*" />
<include name="org/apache/catalina/security/SecurityClassLoad.*" />
<include name="org/apache/catalina/webresources/war/**" />
+ <include name="org/apache/coyote/Constants.*" />
Review comment:
Your BZ doesn't show use of this, so where is this used ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org