You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/12/05 20:25:11 UTC

[GitHub] [hbase] briaugenreich commented on pull request #4853: HBASE-27390: prevent NPE when task status is null

briaugenreich commented on PR #4853:
URL: https://github.com/apache/hbase/pull/4853#issuecomment-1338123031

   @bbeaudreault That makes sense to me. I also had to update `MonitoredRPCHandlerImpl` which extends `MonitoredTaskImpl`. The `MonitoredRPCHandlerImpl` usages in our tests definitely did not follow the convention of always calling setDescription.
   
   I used a precondition check for not null values as I see that's common throughout the code but can add a null check and plain return if that's better. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org