You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/16 08:11:32 UTC
[GitHub] [incubator-nuttx-apps] Donny9 opened a new pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS
Donny9 opened a new pull request #612:
URL: https://github.com/apache/incubator-nuttx-apps/pull/612
## Summary
using THTTPD_NFILE_DESCRIPTORS instead of NFILE_DESCRIPTORS. This patch associates with https://github.com/apache/incubator-nuttx/pull/3045.
## Impact
## Testing
daily test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Donny9 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS
Posted by GitBox <gi...@apache.org>.
Donny9 commented on pull request #612:
URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800304493
> @xiaoxiang781216 Please do.
There are so many such "Mixed case identifier found", Are you sure want to fix them? not just ClientData. Timer, TimerProc, ....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #612:
URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800210542
@xiaoxiang781216 Please do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #612:
URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800330888
@davids5 the violation is huge, let's merge this patch first and create a new PR late to fix the mix case issue since apache/incubator-nuttx#3045 which is a huge patch need to merge, but depends on this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #612:
URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800202737
Yes, we can rename it if no objection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #612:
URL: https://github.com/apache/incubator-nuttx-apps/pull/612
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #612:
URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800189190
It exist for long time, do you want to rename it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #612:
URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800085746
Yes, let ignore it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #612:
URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800330888
@davids5 the violation is huge, let's merge this patch first and create a new PR late to fix the mix case issue since fs: Allocate file/socket dynamically apache/incubator-nuttx#3045 which is also a huge patch need to merge depends on this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #612:
URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800172109
> Yes, let ignore it.
https://github.com/apache/incubator-nuttx-apps/search?q=ClientData&type=code
@xiaoxiang781216 Where is `ClientData` coming in from?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #612:
URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800193265
@xiaoxiang781216 are you asking if you or @Donny9 should fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Donny9 edited a comment on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS
Posted by GitBox <gi...@apache.org>.
Donny9 edited a comment on pull request #612:
URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800080654
```
../nuttx/tools/checkpatch.sh -g 5140962436f816cedfe6f9ff57c699e4d027af09..HEAD
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:100:2: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:101:2: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:132:17: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:132:57: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:133:36: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:134:52: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:135:23: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:135:63: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:530:2: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:600:17: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:600:57: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:611:14: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:618:38: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:623:14: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:628:37: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:635:36: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:636:52: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:646:23: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:646:63: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:733:35: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:742:29: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd_cgi.c:720:2: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd_cgi.c:1100:21: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd_cgi.c:1100:61: error: Mixed case identifier found
```
ignore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Donny9 commented on pull request #612: thttpd: add THTTPD_NFILE_DESCRIPTORS
Posted by GitBox <gi...@apache.org>.
Donny9 commented on pull request #612:
URL: https://github.com/apache/incubator-nuttx-apps/pull/612#issuecomment-800080654
../nuttx/tools/checkpatch.sh -g 5140962436f816cedfe6f9ff57c699e4d027af09..HEAD
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:100:2: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:101:2: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:132:17: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:132:57: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:133:36: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:134:52: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:135:23: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:135:63: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:530:2: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:600:17: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:600:57: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:611:14: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:618:38: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:623:14: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:628:37: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:635:36: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:636:52: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:646:23: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:646:63: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:733:35: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd.c:742:29: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd_cgi.c:720:2: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd_cgi.c:1100:21: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/netutils/thttpd/thttpd_cgi.c:1100:61: error: Mixed case identifier found
ignore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org