You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Ignacio Vera (Jira)" <ji...@apache.org> on 2019/10/16 09:49:00 UTC

[jira] [Resolved] (LUCENE-8746) Make EdgeTree (aka ComponentTree) support different type of components

     [ https://issues.apache.org/jira/browse/LUCENE-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ignacio Vera resolved LUCENE-8746.
----------------------------------
    Fix Version/s: 8.4
         Assignee: Ignacio Vera
       Resolution: Fixed

Thanks [~jpountz] for muting the terst. I have pushed fix ad it seems test are happy. The use was related to the order of the edges of decoded triangles. This is something that Lucene-8997 should improve.

> Make EdgeTree (aka ComponentTree) support different type of components
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-8746
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8746
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Ignacio Vera
>            Assignee: Ignacio Vera
>            Priority: Major
>             Fix For: 8.4
>
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> Currently the class {{EdgeTree}} is a bit confusing as it is in reality a tree of components. The inner class {{Edge}} is the one that builds a tree of edges which is used by Polygon2D and Line2D to represent their structure.
> Here is proposed:
> 1) Create a new class called {{ComponentTree}} which is in fact the current {{EdgeTree}}
> 2) Modify {{EdgeTree}} to be in fact the inner class Edge
> 3) Extract a {{Component}} interface so we can have different types of components in the same tree. This allow us to support heterogeneous trees of components.
> 4) Make {{Polygon2D}} and {{Line2D}} instance of the component interface.
> 4) With this change, {{LatLonShapePolygonQuery}} and {{LatLonShapeLineQuery}} can be replaced with one {{LatLonShapeComponentQuery.}}  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org