You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2015/03/30 10:36:05 UTC
[GitHub] couchdb-fauxton pull request: Loading component
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/342
Loading component
At a small loading component that gets displayed when data is being
fetched.
The loading design can be improved but most importantly this is to showcase the change from a general spinner to appropriate loading components to improve the UX for when a user is waiting for something to load. [Here is a video of it working](https://dl.dropboxusercontent.com/u/33050486/loadingdemo.mov)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrensmith/couchdb-fauxton new-loading-component
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/342.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #342
----
commit d67f8613c23c70db21c3b4bec501bc89576035d9
Author: Garren Smith <ga...@gmail.com>
Date: 2015-03-26T14:46:16Z
Loading component
At a small loading component that gets displayed when data is being
fetched.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Loading component
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/342#discussion_r27374225
--- Diff: app/addons/components/assets/less/loading-lines.less ---
@@ -0,0 +1,65 @@
+@height: 30px;
+@margin: 3px;
+@width: 10px;
--- End diff --
suggestion: more specific name to avoid collisions: e.g.
```
@loadingLinesHeight: 30px;
@loadingLinesMargin: 3px;
@loadingLinesWidth: 10px;
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Loading component
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/342#discussion_r27374430
--- Diff: app/addons/documents/index-results/index-results.components.react.jsx ---
@@ -74,6 +73,11 @@ function (app, FauxtonAPI, React, Stores, Actions, Components, Documents) {
render: function () {
var classNames = 'view';
+ var loadLines = null;
+
+ if (this.props.isLoading) {
+ loadLines = <Components.LoadLines />;
+ }
--- End diff --
can you write a simple test for this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Loading component
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/342#discussion_r27374322
--- Diff: app/addons/components/react-components.react.jsx ---
@@ -258,6 +258,23 @@ function (app, FauxtonAPI, React, Components, beautifyHelper) {
}
});
+ var LoadLines = React.createClass({
+
+ render: function () {
+
+ return (
+ <div id="loading-lines">
--- End diff --
can we switch it to a class? it gets more reusable, then we can have multiple areas on the page using the loadinglines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Loading component
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/342#issuecomment-87643395
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Loading component
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/342#issuecomment-87642731
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Loading component
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/342#issuecomment-87591842
A gif in case the video didn't load.
[gif](https://dl.dropboxusercontent.com/u/33050486/loadingdemo1.gif)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Loading component
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/342
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---