[GitHub] [flink] XComp commented on a diff in pull request #22052: [FLINK-31278] Disables fork reuse and parallel execution for flink-core package

["XComp (via GitHub)" <gi...@apache.org>]

XComp commented on code in PR #22052:
URL: https://github.com/apache/flink/pull/22052#discussion_r1121429475


##########
flink-core/pom.xml:
##########
@@ -146,6 +146,30 @@ under the License.
 				</configuration>
 			</plugin>
 
+			<!-- The following configuration is used to debug https://issues.apache.org/jira/browse/FLINK-31278.
+			Overriding the surefire config can be removed after FLINK-31278 is resolved. -->
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-surefire-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>default-tests</id>
+						<phase>test</phase>
+						<goals>
+							<goal>test</goal>
+						</goals>
+						<configuration>
+							<includes>
+								<include>${test.unit.pattern}</include>
+							</includes>
+							<argLine>${flink.surefire.baseArgLine} -Xmx${flink.XmxUnitTest} -XX:+HeapDumpOnOutOfMemoryError</argLine>

Review Comment:
   ```suggestion
   							<argLine>${flink.surefire.baseArgLine} -Xmx${flink.XmxUnitTest} -XX:+HeapDumpOnOutOfMemoryError</argLine>
   ```
   @zentol I feel like I'm missing something here: Isn't `-XX:+HeapDumpOnOutOfMemoryError` a good thing to have in general in the surefire configuration? I couldn't find anywhere that this is enabled by default. But I cannot imagine that we haven't considered it before with all the OOMs we had to deal with in the past.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org