You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/03 13:02:30 UTC

[GitHub] [arrow-datafusion] jackwener opened a new pull request, #4802: add tpch sqllogicaltest and remove some duplicated test

jackwener opened a new pull request, #4802:
URL: https://github.com/apache/arrow-datafusion/pull/4802

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #4801.
   
   # Rationale for this change
   
   
   
   # What changes are included in this PR?
   
   - add tpch sqllogicaltest
   - remove some duplicated test. #4801
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jackwener commented on pull request #4802: add tpch sqllogicaltest and remove some duplicated test

Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #4802:
URL: https://github.com/apache/arrow-datafusion/pull/4802#issuecomment-1369877140

   > These tests are really to check that subqueries get rewritten as joins rather than being about tpch. The change in the test here just checks for correct results and does not check the details of how the plans are rewritten, so I feel like we are losing some value with this change. However, we also check for expected plans in tpch so maybe this is fine. Would be good to check with @avantgardnerio who originally implemented these tests, or @iajoiner.
   
   But these test already exist, they are same with tpch-test.
   
   like 
   - https://github.com/apache/arrow-datafusion/blob/master/benchmarks/expected-plans/q2.txt
   - https://github.com/apache/arrow-datafusion/blob/master/benchmarks/expected-plans/q4.txt
   - https://github.com/apache/arrow-datafusion/blob/master/benchmarks/expected-plans/q17.txt
   - https://github.com/apache/arrow-datafusion/blob/master/benchmarks/expected-plans/q20.txt
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jackwener commented on pull request #4802: add tpch sqllogicaltest and remove some duplicated test

Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #4802:
URL: https://github.com/apache/arrow-datafusion/pull/4802#issuecomment-1369886777

   > These tests are really to check that subqueries get rewritten as joins rather than being about tpch. The change in the test here just checks for correct results and does not check the details of how the plans are rewritten, so I feel like we are losing some value with this change. However, we also check for expected plans in tpch so maybe this is fine. Would be good to check with @avantgardnerio who originally implemented these tests, or @iajoiner.
   
   My mistakešŸ„², after a careful comparison, I find that they are not exactly the same .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] ursabot commented on pull request #4802: add tpch sqllogicaltest and remove some duplicated test

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4802:
URL: https://github.com/apache/arrow-datafusion/pull/4802#issuecomment-1374947198

   Benchmark runs are scheduled for baseline = 63ae2b9ebbe853648492576cda457a3049bbd2dc and contender = e393b28271b0e05274ea525de33a96b12a8a2ab5. e393b28271b0e05274ea525de33a96b12a8a2ab5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/2716f96046f148f1abea85fc7d0b842a...de85cc1491394c719cc167c33952b809/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/77a77cec038c467aab9a59ce43299dc0...499a49273ab64bd2869b509fb8b24de5/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/39a2b37c2426429ab4186cf100ab044c...fbf995b3e0644b16a488ec8bf1675359/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8eef88d18084afa9a9158869dfa7e66...1ad6b047d37249d4a446a22bbfe89ff8/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jackwener commented on pull request #4802: add tpch sqllogicaltest and remove some duplicated test

Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #4802:
URL: https://github.com/apache/arrow-datafusion/pull/4802#issuecomment-1369743987

   Some query result is strange, but run successfully.šŸ¤”


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #4802: add tpch sqllogicaltest and remove some duplicated test

Posted by GitBox <gi...@apache.org>.
alamb merged PR #4802:
URL: https://github.com/apache/arrow-datafusion/pull/4802


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove commented on pull request #4802: add tpch sqllogicaltest and remove some duplicated test

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #4802:
URL: https://github.com/apache/arrow-datafusion/pull/4802#issuecomment-1369862347

   These tests are really to check that subqueries get rewritten as joins rather than being about tpch. The change in the test here just checks for correct results and does not check the details of how the plans are rewritten, so I feel like we are losing some value with this change. However, we also check for expected plans in tpch so maybe this is fine. Would be good to check with @avantgardnerio who originally implemented these tests, or @iajoiner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org