[GitHub] [calcite] rubenada commented on a change in pull request #1576: [CALCITE-3285] EnumerableMergeJoin should support non-equi join condi…

[GitBox <gi...@apache.org>]

rubenada commented on a change in pull request #1576: [CALCITE-3285] EnumerableMergeJoin should support non-equi join condi…
URL: https://github.com/apache/calcite/pull/1576#discussion_r345794095
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java
 ##########
 @@ -268,6 +276,48 @@ static JoinType toLinq4jJoinType(JoinRelType joinRelType) {
     throw new IllegalStateException(
         "Unable to convert " + joinRelType + " to Linq4j JoinType");
   }
+
+  /**
+   * Generate Expression for Join condition, 'excludeEquiCondition'
+   * indicates whether to exclude equi-join conditions for the result.
+   */
+  static Expression generatePredicateForJoin(
 
 Review comment:
   @jinxing64 please note that this refactoring was already implemented via https://github.com/apache/calcite/pull/1424/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services