You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/06/12 16:08:01 UTC

Review Request 67546: Moved RecordIO documentation into separate file.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67546/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Jan Schlicht.


Repository: mesos


Description
-------

Created a new file 'docs/recordio.md' that expands upon the description of the RecordIO data format, which was previously described in 'scheduler-http-api.md'.


Diffs
-----

  docs/home.md adefc4d9e6be3635d6c984712096ebf8722f1841 
  docs/operator-http-api.md c0f20c00f27ac5c81d4b56f166ea4140b5305096 
  docs/recordio.md PRE-CREATION 
  docs/scheduler-http-api.md bea8817e4cb275d21055eed501c7af0b4b056a9e 


Diff: https://reviews.apache.org/r/67546/diff/1/


Testing
-------

Nope.


Thanks,

Benno Evers


Re: Review Request 67546: Moved RecordIO documentation into separate file.

Posted by Alexander Rukletsov <ru...@gmail.com>.

> On June 12, 2018, 5:38 p.m., Alexander Rukletsov wrote:
> > docs/recordio.md
> > Lines 26 (patched)
> > <https://reviews.apache.org/r/67546/diff/1/?file=2039761#file2039761line26>
> >
> >     ##

##


> On June 12, 2018, 5:38 p.m., Alexander Rukletsov wrote:
> > docs/recordio.md
> > Lines 69 (patched)
> > <https://reviews.apache.org/r/67546/diff/1/?file=2039761#file2039761line69>
> >
> >     ##

##


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67546/#review204610
-----------------------------------------------------------


On June 12, 2018, 4:08 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67546/
> -----------------------------------------------------------
> 
> (Updated June 12, 2018, 4:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Created a new file 'docs/recordio.md' that expands upon the description of the RecordIO data format, which was previously described in 'scheduler-http-api.md'.
> 
> 
> Diffs
> -----
> 
>   docs/home.md adefc4d9e6be3635d6c984712096ebf8722f1841 
>   docs/operator-http-api.md c0f20c00f27ac5c81d4b56f166ea4140b5305096 
>   docs/recordio.md PRE-CREATION 
>   docs/scheduler-http-api.md bea8817e4cb275d21055eed501c7af0b4b056a9e 
> 
> 
> Diff: https://reviews.apache.org/r/67546/diff/1/
> 
> 
> Testing
> -------
> 
> Nope.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 67546: Moved RecordIO documentation into separate file.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67546/#review204610
-----------------------------------------------------------


Fix it, then Ship it!





docs/recordio.md
Lines 26 (patched)
<https://reviews.apache.org/r/67546/#comment287193>

    ##



docs/recordio.md
Lines 69 (patched)
<https://reviews.apache.org/r/67546/#comment287192>

    ##


- Alexander Rukletsov


On June 12, 2018, 4:08 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67546/
> -----------------------------------------------------------
> 
> (Updated June 12, 2018, 4:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Created a new file 'docs/recordio.md' that expands upon the description of the RecordIO data format, which was previously described in 'scheduler-http-api.md'.
> 
> 
> Diffs
> -----
> 
>   docs/home.md adefc4d9e6be3635d6c984712096ebf8722f1841 
>   docs/operator-http-api.md c0f20c00f27ac5c81d4b56f166ea4140b5305096 
>   docs/recordio.md PRE-CREATION 
>   docs/scheduler-http-api.md bea8817e4cb275d21055eed501c7af0b4b056a9e 
> 
> 
> Diff: https://reviews.apache.org/r/67546/diff/1/
> 
> 
> Testing
> -------
> 
> Nope.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>