You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2017/12/01 21:17:12 UTC

svn commit: r1816911 - in /jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler: JMSSampler.java TimeoutEnabledQueueRequestor.java

Author: pmouawad
Date: Fri Dec  1 21:17:12 2017
New Revision: 1816911

URL: http://svn.apache.org/viewvc?rev=1816911&view=rev
Log:
Fix SONAR warnings

Modified:
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java
    jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/TimeoutEnabledQueueRequestor.java

Modified: jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java?rev=1816911&r1=1816910&r2=1816911&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java (original)
+++ jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java Fri Dec  1 21:17:12 2017
@@ -866,7 +866,10 @@ public class JMSSampler extends Abstract
         int val = 1;
         try {
             val = getPropertyAsInt(JMS_NUMBEROFSAMPLES);
-        } catch (Exception e) {
+        } catch (Exception e) { // NOSONAR
+            if(LOGGER.isDebugEnabled()) {
+                LOGGER.debug("Failed parsing number of samples to aggregate");
+            }
             val = 1;
         }
         if (val < 1) {

Modified: jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/TimeoutEnabledQueueRequestor.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/TimeoutEnabledQueueRequestor.java?rev=1816911&r1=1816910&r2=1816911&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/TimeoutEnabledQueueRequestor.java (original)
+++ jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/TimeoutEnabledQueueRequestor.java Fri Dec  1 21:17:12 2017
@@ -138,18 +138,18 @@ public class TimeoutEnabledQueueRequesto
         String queueName = tempQueue.getQueueName();
         try {
             sender.close();
-        } catch (Exception e1) {
-            logger.error("Error closing sender");
+        } catch (Exception ex) {
+            logger.error("Error closing sender", ex);
         }
         try {
             receiver.close();
-        } catch (Exception e1) {
-            logger.error("Error closing receiver");
+        } catch (Exception ex) {
+            logger.error("Error closing receiver", ex);
         }
         try {
             tempQueue.delete();
-        } catch (Exception e) {
-            logger.error("Error deleting tempQueue {}", queueName);
+        } catch (Exception ex) {
+            logger.error("Error deleting tempQueue {}", queueName, ex);
         }
     }
 }