[jira] Commented: (CASSANDRA-130) uniform logging of read/write paths

["Eric Evans (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705674#action_12705674 ] 

Eric Evans commented on CASSANDRA-130:
--------------------------------------

As you pointed out on IRC, this needs the following to successfully build:

diff --git a/src/java/org/apache/cassandra/service/StorageProxy.java b/src/java/
index 456b637..ea8ee40 100644
--- a/src/java/org/apache/cassandra/service/StorageProxy.java
+++ b/src/java/org/apache/cassandra/service/StorageProxy.java
@@ -674,7 +674,7 @@ public class StorageProxy implements StorageProxyMBean
 
             // read response
             // TODO send more requests if we need to span multiple nodes
-            byte[] responseBody = iar.get(DatabaseDescriptor.getRpcTimeout(), T
+            byte[] responseBody = (byte[])iar.get(DatabaseDescriptor.getRpcTime
             return RangeReply.read(responseBody).keys;
         }
         catch (Exception e)

Also, it looks like the patch creates a file named src/java/org/apache/cassandra/db/ColumnFamilyStore.java.orig, and I assume that was unintentional.

It looks possible for the {range,read,write}Operations of StorageProxy to be incremented beyond the limit of an int, (so maybe they should roll over to zero at overflow).


> uniform logging of read/write paths
> -----------------------------------
>
>                 Key: CASSANDRA-130
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-130
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: trunk
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.3
>
>         Attachments: 130-v2.patch, 130.patch
>
>
> lots of stuff is logged but mostly haphazardly.  need to make it so we can usefully track data path for troubleshooting.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.