You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Juan Pablo Santos Rodríguez (JIRA)" <ji...@apache.org> on 2012/07/11 23:37:35 UTC
[jira] [Created] (JSPWIKI-738) Dependencies should not be
distributed with source archive
Juan Pablo Santos Rodríguez created JSPWIKI-738:
---------------------------------------------------
Summary: Dependencies should not be distributed with source archive
Key: JSPWIKI-738
URL: https://issues.apache.org/jira/browse/JSPWIKI-738
Project: JSPWiki
Issue Type: Task
Affects Versions: 2.9
Reporter: Juan Pablo Santos Rodríguez
Fix For: 2.9
As pointed out in the revision of the July 2012 incubation report, JSPWiki ships binary dependencies in the source archive, which is contrary to Apache principles.
As we are downloading some dependencies in current trunk, I would take the path of downloading all needed jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JSPWIKI-738) Dependencies should not be
distributed with source archive
Posted by "Juan Pablo Santos Rodríguez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428928#comment-13428928 ]
Juan Pablo Santos Rodríguez commented on JSPWIKI-738:
-----------------------------------------------------
Hello Florian,
there are several things to note:
The download mechanism: it was introduced because having external jars in the source code is considered against Apache principles, which was noted in the follow-up of the [July status report|http://mail-archives.apache.org/mod_mbox/incubator-general/201207.mbox/%3CCAOFYJNZFBUrQ1itE-U6naBrr6pATsc+DZ_Jc6t3s31uEphTaKA@mail.gmail.com%3E]. Keeping the jars in libs tests/libs will most probably be a blocker for IPMC.
The growing libs directory: I'm thinking we could avoid that problem by directly download them from Central, except for sandler and freshcookies-security, which are not available there.
maven ant tasks: to introduce cobertura and sonar support we needed some (L)GPL jars, which we couldn't have in our SVN repository, hence the mechanism to download them. I was thinking of downloading all dependencies via these tasks, but as sandler and freshcookies-security are not published on central, so may be we could just download the needed jars from central and get rid off these tasks. Thoughts?
> Dependencies should not be distributed with source archive
> ----------------------------------------------------------
>
> Key: JSPWIKI-738
> URL: https://issues.apache.org/jira/browse/JSPWIKI-738
> Project: JSPWiki
> Issue Type: Task
> Affects Versions: Graduating, 2.9
> Reporter: Juan Pablo Santos Rodríguez
> Assignee: Juan Pablo Santos Rodríguez
> Fix For: Graduating, 2.9
>
>
> As pointed out in the revision of the July 2012 incubation report, JSPWiki ships binary dependencies in the source archive, which is contrary to Apache principles.
> As we are downloading some dependencies in current trunk, I would take the path of downloading all needed jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JSPWIKI-738) Dependencies should not be
distributed with source archive
Posted by "Juan Pablo Santos Rodríguez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418170#comment-13418170 ]
Juan Pablo Santos Rodríguez commented on JSPWIKI-738:
-----------------------------------------------------
Hallo Florian,
I'll take a look this afternoon/tonight. Please reopen and attach relevant tomcat logs to see what's happening.
Regarding servlet-api, we were including 2.4 although we're stating it should run on 2.3. AFAIK it deploys on tomcat 5.5, so, theorically, we could probably downgrade the servlet-api to 2.3. Haven't done tests on this, though.
regards,
juan pablo
> Dependencies should not be distributed with source archive
> ----------------------------------------------------------
>
> Key: JSPWIKI-738
> URL: https://issues.apache.org/jira/browse/JSPWIKI-738
> Project: JSPWiki
> Issue Type: Task
> Affects Versions: Graduating, 2.9
> Reporter: Juan Pablo Santos Rodríguez
> Assignee: Juan Pablo Santos Rodríguez
> Fix For: Graduating, 2.9
>
>
> As pointed out in the revision of the July 2012 incubation report, JSPWiki ships binary dependencies in the source archive, which is contrary to Apache principles.
> As we are downloading some dependencies in current trunk, I would take the path of downloading all needed jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JSPWIKI-738) Dependencies should not be
distributed with source archive
Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Florian Holeczek updated JSPWIKI-738:
-------------------------------------
Affects Version/s: Graduating
Fix Version/s: Graduating
> Dependencies should not be distributed with source archive
> ----------------------------------------------------------
>
> Key: JSPWIKI-738
> URL: https://issues.apache.org/jira/browse/JSPWIKI-738
> Project: JSPWiki
> Issue Type: Task
> Affects Versions: Graduating, 2.9
> Reporter: Juan Pablo Santos Rodríguez
> Fix For: Graduating, 2.9
>
>
> As pointed out in the revision of the July 2012 incubation report, JSPWiki ships binary dependencies in the source archive, which is contrary to Apache principles.
> As we are downloading some dependencies in current trunk, I would take the path of downloading all needed jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (JSPWIKI-738) Dependencies should not be
distributed with source archive
Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Florian Holeczek closed JSPWIKI-738.
------------------------------------
Closing this, since 2.9 has been released
> Dependencies should not be distributed with source archive
> ----------------------------------------------------------
>
> Key: JSPWIKI-738
> URL: https://issues.apache.org/jira/browse/JSPWIKI-738
> Project: JSPWiki
> Issue Type: Task
> Affects Versions: Graduating, 2.9
> Reporter: Juan Pablo Santos Rodríguez
> Assignee: Juan Pablo Santos Rodríguez
> Fix For: Graduating, 2.9
>
>
> As pointed out in the revision of the July 2012 incubation report, JSPWiki ships binary dependencies in the source archive, which is contrary to Apache principles.
> As we are downloading some dependencies in current trunk, I would take the path of downloading all needed jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JSPWIKI-738) Dependencies should not be
distributed with source archive
Posted by "Juan Pablo Santos Rodríguez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juan Pablo Santos Rodríguez resolved JSPWIKI-738.
-------------------------------------------------
Resolution: Fixed
done, both jars are properly excluded from war now.
Regarding servlet-api, doc/Compiling.txt states a 2.4 version for servlet-api.
I think the best we can do is upload the info on that file to the site with the proper explanations, so that information gets really visible.
regards,
juan pablo
> Dependencies should not be distributed with source archive
> ----------------------------------------------------------
>
> Key: JSPWIKI-738
> URL: https://issues.apache.org/jira/browse/JSPWIKI-738
> Project: JSPWiki
> Issue Type: Task
> Affects Versions: Graduating, 2.9
> Reporter: Juan Pablo Santos Rodríguez
> Assignee: Juan Pablo Santos Rodríguez
> Fix For: Graduating, 2.9
>
>
> As pointed out in the revision of the July 2012 incubation report, JSPWiki ships binary dependencies in the source archive, which is contrary to Apache principles.
> As we are downloading some dependencies in current trunk, I would take the path of downloading all needed jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JSPWIKI-738) Dependencies should not be
distributed with source archive
Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428911#comment-13428911 ]
Florian Holeczek commented on JSPWIKI-738:
------------------------------------------
Juan Pablo, I have some questions and thoughts on the currently implemented solution:
What is the exact requirement and where is it documented at ASF?
IMO we're dealing with two aspects here:
* (binary) dependencies in the source artifact
* dependency handling in the project
Taking the title, "Dependencies should not be distributed with source archive", as the requirement, wouldn't it be enough to simply exclude the libs from being added to the ZIP file?
Regarding dependency management: Is there a reason for not leaving the libs under libs and test/libs in the trunk, branch, etc.? With the current solution, we will have a growing libs directory on the top level, since we still need all older versions in there in order to be able to still build older versions.
> Dependencies should not be distributed with source archive
> ----------------------------------------------------------
>
> Key: JSPWIKI-738
> URL: https://issues.apache.org/jira/browse/JSPWIKI-738
> Project: JSPWiki
> Issue Type: Task
> Affects Versions: Graduating, 2.9
> Reporter: Juan Pablo Santos Rodríguez
> Assignee: Juan Pablo Santos Rodríguez
> Fix For: Graduating, 2.9
>
>
> As pointed out in the revision of the July 2012 incubation report, JSPWiki ships binary dependencies in the source archive, which is contrary to Apache principles.
> As we are downloading some dependencies in current trunk, I would take the path of downloading all needed jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JSPWIKI-738) Dependencies should not be
distributed with source archive
Posted by "Juan Pablo Santos Rodríguez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juan Pablo Santos Rodríguez resolved JSPWIKI-738.
-------------------------------------------------
Resolution: Fixed
done in 2.9.0-incubating-7
> Dependencies should not be distributed with source archive
> ----------------------------------------------------------
>
> Key: JSPWIKI-738
> URL: https://issues.apache.org/jira/browse/JSPWIKI-738
> Project: JSPWiki
> Issue Type: Task
> Affects Versions: Graduating, 2.9
> Reporter: Juan Pablo Santos Rodríguez
> Fix For: Graduating, 2.9
>
>
> As pointed out in the revision of the July 2012 incubation report, JSPWiki ships binary dependencies in the source archive, which is contrary to Apache principles.
> As we are downloading some dependencies in current trunk, I would take the path of downloading all needed jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JSPWIKI-738) Dependencies should not be
distributed with source archive
Posted by "Juan Pablo Santos Rodríguez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414616#comment-13414616 ]
Juan Pablo Santos Rodríguez commented on JSPWIKI-738:
-----------------------------------------------------
Using maven-ant-tasks to download all the required dependencies may not be the cleanest solution for current trunk:
* we would have to download maven-ant-tasks by other means
* freshcookies-security jar isn't on central/apache repos, so we would have to download it by other means
* would have to manage/configure transitive dependencies, which is easy for a Maven build, but not so when doing through maven-ant-tasks
Following up with the [JSPWiki status from July 2012 report|http://mail-archives.apache.org/mod_mbox/incubator-general/201207.mbox/%3C1EAFFA29-8B47-474E-B50B-ACBC352C0AE7@comcast.net%3E], it seems that the easiest way would be to just download the libs from SVN, with a script similar to the Apache POI one, having in $SVN something like:
{noformat} $SVN
+ trunk
+ tags
+ branches
+ [...]
+ libs
> main
> test
{noformat}
Regarding sonar & cobertura tasks, I would leave them as they are now, in order to avoid uploading LGPL libs to $SVN
> Dependencies should not be distributed with source archive
> ----------------------------------------------------------
>
> Key: JSPWIKI-738
> URL: https://issues.apache.org/jira/browse/JSPWIKI-738
> Project: JSPWiki
> Issue Type: Task
> Affects Versions: 2.9
> Reporter: Juan Pablo Santos Rodríguez
> Fix For: 2.9
>
>
> As pointed out in the revision of the July 2012 incubation report, JSPWiki ships binary dependencies in the source archive, which is contrary to Apache principles.
> As we are downloading some dependencies in current trunk, I would take the path of downloading all needed jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JSPWIKI-738) Dependencies should not be
distributed with source archive
Posted by "Janne Jalkanen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419501#comment-13419501 ]
Janne Jalkanen commented on JSPWIKI-738:
----------------------------------------
We're currently doing something like this: first have a pom.xml with the dependencies (which will include transitive stuff) and then in the build.xml have something like this:
{code:xml}
<!--
Maven ant tasks
-->
<property name="mvn.jar.dir" value="${user.home}/.ant"/>
<target name="download-mvn">
<mkdir dir="${mvn.jar.dir}"/>
<get src="http://www.nic.funet.fi/pub/mirrors/apache.org/maven/binaries/maven-ant-tasks-2.1.3.jar " dest="${mvn.jar.dir}" usetimestamp="true" skipexisting="true" />
</target>
<target name="init-mvn" depends="download-mvn" unless="mvn.init.called">
<path id="maven-ant-tasks.classpath" path="${mvn.jar.dir}/maven-ant-tasks-2.1.3.jar" />
<typedef resource="org/apache/maven/artifact/ant/antlib.xml"
uri="antlib:org.apache.maven.artifact.ant"
classpathref="maven-ant-tasks.classpath" />
<artifact:pom id="pom" file="pom.xml" />
<artifact:dependencies filesetId="mvn.fileset" pathId="mvn.classpath" pomRefId="pom" scopes="provided,compile"/>
<property name="mvn.init.called" value="true" />
</target>
{code}
> Dependencies should not be distributed with source archive
> ----------------------------------------------------------
>
> Key: JSPWIKI-738
> URL: https://issues.apache.org/jira/browse/JSPWIKI-738
> Project: JSPWiki
> Issue Type: Task
> Affects Versions: Graduating, 2.9
> Reporter: Juan Pablo Santos Rodríguez
> Assignee: Juan Pablo Santos Rodríguez
> Fix For: Graduating, 2.9
>
>
> As pointed out in the revision of the July 2012 incubation report, JSPWiki ships binary dependencies in the source archive, which is contrary to Apache principles.
> As we are downloading some dependencies in current trunk, I would take the path of downloading all needed jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JSPWIKI-738) Dependencies should not be
distributed with source archive
Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418177#comment-13418177 ]
Florian Holeczek commented on JSPWIKI-738:
------------------------------------------
Ok, so deleting the servlet-api as well as the jsp-api JARs from WEB-INF/lib does it! These hadn't been included before either.
Regarding the API version, I think it's only a matter of decision. If we want to keep on supporting 2.3, we should downgrade to these libraries. Otherwise, we should clearly state that 2.3 should work, but we don't support it. The Servlet and JSP APIs have always been upwards compatible yet, haven't they?
> Dependencies should not be distributed with source archive
> ----------------------------------------------------------
>
> Key: JSPWIKI-738
> URL: https://issues.apache.org/jira/browse/JSPWIKI-738
> Project: JSPWiki
> Issue Type: Task
> Affects Versions: Graduating, 2.9
> Reporter: Juan Pablo Santos Rodríguez
> Assignee: Juan Pablo Santos Rodríguez
> Fix For: Graduating, 2.9
>
>
> As pointed out in the revision of the July 2012 incubation report, JSPWiki ships binary dependencies in the source archive, which is contrary to Apache principles.
> As we are downloading some dependencies in current trunk, I would take the path of downloading all needed jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (JSPWIKI-738) Dependencies should not be
distributed with source archive
Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JSPWIKI-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Florian Holeczek reopened JSPWIKI-738:
--------------------------------------
Assignee: Juan Pablo Santos Rodríguez
Hi Juan Pablo,
nice work, it's building the distribution archives without any errors and without any binary libs in the source archive.
However, I couldn't get the output up and running on my Tomcat 6 instance. There seem to be problems regarding the Servlet and/or JSP API. Deleting the servlet-api-2.4.jar from WEB-INF/lib didn't help.
Please also note that we're saying to require a Servlet 2.3 container only so far.
Regards
Florian
> Dependencies should not be distributed with source archive
> ----------------------------------------------------------
>
> Key: JSPWIKI-738
> URL: https://issues.apache.org/jira/browse/JSPWIKI-738
> Project: JSPWiki
> Issue Type: Task
> Affects Versions: Graduating, 2.9
> Reporter: Juan Pablo Santos Rodríguez
> Assignee: Juan Pablo Santos Rodríguez
> Fix For: Graduating, 2.9
>
>
> As pointed out in the revision of the July 2012 incubation report, JSPWiki ships binary dependencies in the source archive, which is contrary to Apache principles.
> As we are downloading some dependencies in current trunk, I would take the path of downloading all needed jars.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira