[GitHub] [lucene-solr] HoustonPutman commented on pull request #1769: SOLR-14789: Absorb the docker-solr repo.

[GitBox <gi...@apache.org>]

HoustonPutman commented on pull request #1769:
URL: https://github.com/apache/lucene-solr/pull/1769#issuecomment-728185520


   The extra step exists because there was no consensus around how to do official release images.
   
   If we want to decide that the official image should be built the same way as it currently is in the project (via the local build), then we can get rid of the sub-module and the extra step. However if we want to have the official image use the official release binaries, as it does in `docker-solr`, then we will need to keep the submodule.
   
   I would have preferred to have all of this done in one module, but the gradle docker plugin only supports building one image per-module. So if we want to build multiple images (which is necessary for supporting the two image types, local and release), we need two modules.
   
   I am all for not adding support for official binary release strategy, and consolidating into one docker file. I just don't want to make that decision unanimously. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org