You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/08/18 22:10:56 UTC
[GitHub] [helix] NealSun96 opened a new pull request #1842: Fix TestClusterAggregateMetrics
NealSun96 opened a new pull request #1842:
URL: https://github.com/apache/helix/pull/1842
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1806
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
Fix flaky TestClusterAggregateMetrics by wrapping maintenance mode around batch enabling of instances, otherwise the events may be processed separately, resulting in an intermediate best possible state that does not represent the final state.
### Tests
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on pull request #1842: Fix TestClusterAggregateMetrics
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on pull request #1842:
URL: https://github.com/apache/helix/pull/1842#issuecomment-902962775
This PR is ready to be merged, approved by @junkaixue
Final commit message:
## Fix TestClusterAggregateMetrics ##
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] alirezazamani merged pull request #1842: Fix TestClusterAggregateMetrics
Posted by GitBox <gi...@apache.org>.
alirezazamani merged pull request #1842:
URL: https://github.com/apache/helix/pull/1842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1842: Fix TestClusterAggregateMetrics
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1842:
URL: https://github.com/apache/helix/pull/1842#issuecomment-904130368
A better way, or IMHO the correct way, is to wait until the cluster state converged. The main reason we might get unexpected results is that the controller is still rebalancing the cluster while the assert check happens. Given that saying, the current change will reduce the error by reducing pipeline running. But it is not guaranteed since only one pipeline can still run slowly.
Could you please change the test logic to wait until the cluster converges then start validation? Note the verifier should support validate instance state in the call. So you can specify the expected disabled nodes in the same check to ensure verifier does not return prematurely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1842: Fix TestClusterAggregateMetrics
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1842:
URL: https://github.com/apache/helix/pull/1842#issuecomment-923301195
> @jiajunwang On line 178 we have `Assert.assertTrue(verifier.verifyByPolling());` That checks for cluster convergence like you said.
>
> The previous test causes the verifier to mistakenly verify an intermediate state instead of the final state; adding the maintenance mode should mitigate that, and let the verifier do its job.
I had the impression that this verifier is not enough if not validating disabled nodes during the wait. But I guess you are right that what we've done here is the best possible way for NOW. Eventually, we need to fix https://github.com/apache/helix/issues/526.
Let's keep the PR unchanged, it shall minimize the failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on pull request #1842: Fix TestClusterAggregateMetrics
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on pull request #1842:
URL: https://github.com/apache/helix/pull/1842#issuecomment-923187331
@jiajunwang On line 178 we have `Assert.assertTrue(verifier.verifyByPolling());` That checks for cluster convergence like you said.
The previous test causes the verifier to mistakenly verify an intermediate state instead of the final state; adding the maintenance mode should mitigate that, and let the verifier do its job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org