You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Karishma Gulati <gu...@yahoo.com> on 2015/02/06 09:01:12 UTC

Review Request 30719: [Falcon-1010] Add documentation in falcon-regression's README.md, making it easy for contributors to add tests to falcon-regression

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30719/
-----------------------------------------------------------

Review request for Falcon.


Repository: falcon-git


Description
-------

This is a small step in initiating easy contribution to falcon-regression as well, so that falcon-regression's development comes at par with falcon's development.


Diffs
-----

  falcon-regression/README.md 5e1743c 

Diff: https://reviews.apache.org/r/30719/diff/


Testing
-------


Thanks,

Karishma Gulati


Re: Review Request 30719: [Falcon-1010] Add documentation in falcon-regression's README.md, making it easy for contributors to add tests to falcon-regression

Posted by samarth gupta <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30719/#review75294
-----------------------------------------------------------



falcon-regression/README.md
<https://reviews.apache.org/r/30719/#comment122272>

    we can remove "it's as easy as it gets." part :). 
    just follow the below steps should be enough.


- samarth gupta


On March 3, 2015, 12:47 p.m., Karishma Gulati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30719/
> -----------------------------------------------------------
> 
> (Updated March 3, 2015, 12:47 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> This is a small step in initiating easy contribution to falcon-regression as well, so that falcon-regression's development comes at par with falcon's development.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/README.md 5e1743c 
> 
> Diff: https://reviews.apache.org/r/30719/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Karishma Gulati
> 
>


Re: Review Request 30719: [Falcon-1010] Add documentation in falcon-regression's README.md, making it easy for contributors to add tests to falcon-regression

Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30719/#review75875
-----------------------------------------------------------

Ship it!


Ship It!

- Paul Isaychuk


On March 5, 2015, 7:15 a.m., Karishma Gulati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30719/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 7:15 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> This is a small step in initiating easy contribution to falcon-regression as well, so that falcon-regression's development comes at par with falcon's development.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/README.md 5e1743c 
> 
> Diff: https://reviews.apache.org/r/30719/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Karishma Gulati
> 
>


Re: Review Request 30719: [Falcon-1010] Add documentation in falcon-regression's README.md, making it easy for contributors to add tests to falcon-regression

Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30719/
-----------------------------------------------------------

(Updated March 5, 2015, 7:15 a.m.)


Review request for Falcon.


Repository: falcon-git


Description
-------

This is a small step in initiating easy contribution to falcon-regression as well, so that falcon-regression's development comes at par with falcon's development.


Diffs (updated)
-----

  falcon-regression/README.md 5e1743c 

Diff: https://reviews.apache.org/r/30719/diff/


Testing
-------


Thanks,

Karishma Gulati


Re: Review Request 30719: [Falcon-1010] Add documentation in falcon-regression's README.md, making it easy for contributors to add tests to falcon-regression

Posted by Karishma Gulati <gu...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30719/
-----------------------------------------------------------

(Updated March 3, 2015, 12:47 p.m.)


Review request for Falcon.


Repository: falcon-git


Description
-------

This is a small step in initiating easy contribution to falcon-regression as well, so that falcon-regression's development comes at par with falcon's development.


Diffs (updated)
-----

  falcon-regression/README.md 5e1743c 

Diff: https://reviews.apache.org/r/30719/diff/


Testing
-------


Thanks,

Karishma Gulati


Re: Review Request 30719: [Falcon-1010] Add documentation in falcon-regression's README.md, making it easy for contributors to add tests to falcon-regression

Posted by Srikanth Sundarrajan <sr...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30719/#review72678
-----------------------------------------------------------



falcon-regression/README.md
<https://reviews.apache.org/r/30719/#comment118739>

    Does it make sense to put sections of code to support the commentary as opposed to commentary/notes added to sections of the code.


- Srikanth Sundarrajan


On Feb. 6, 2015, 8:01 a.m., Karishma Gulati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30719/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 8:01 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> This is a small step in initiating easy contribution to falcon-regression as well, so that falcon-regression's development comes at par with falcon's development.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/README.md 5e1743c 
> 
> Diff: https://reviews.apache.org/r/30719/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Karishma Gulati
> 
>