[jira] [Commented] (FLINK-6462) Add requiresOver interface for AggregateFunction

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002359#comment-16002359 ] 

ASF GitHub Bot commented on FLINK-6462:
---------------------------------------

GitHub user sunjincheng121 opened a pull request:

    https://github.com/apache/flink/pull/3851

    [FLINK-6462] [table] Add requiresOver interface for AggregateFunction

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-6462] [table] Add requiresOver interface for AggregateFunction ")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sunjincheng121/flink FLINK-6462-PR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3851.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3851
    
----
commit 9a474ebccd13f5a394c77a7e4d701fc16a3772f2
Author: sunjincheng121 <su...@gmail.com>
Date:   2017-05-08T04:04:47Z

    [FLINK-6462] [table] Add requiresOver interface for AggregateFunction

----


> Add requiresOver interface for  AggregateFunction
> -------------------------------------------------
>
>                 Key: FLINK-6462
>                 URL: https://issues.apache.org/jira/browse/FLINK-6462
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> The window function in the standard database only supports the "over" window, such as `LAG`,` LEAD`, `FIRST_VALUE`,` LAST_VALUE`. These window functions do not apply to `Slide`,` Tumble`, `Session` window. So when the user-defined AGG need to be clearly defined. In calcite `SqlAggFunction` will using `requiresOver` to distinguish. 
> In this JIRA. will deal with this feature.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)