You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by "Ethan Wang (JIRA)" <ji...@apache.org> on 2017/12/22 20:27:00 UTC

[jira] [Commented] (PHOENIX-4488) Cache config parameters for MetaDataEndPointImpl during initialization

    [ https://issues.apache.org/jira/browse/PHOENIX-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301922#comment-16301922 ] 

Ethan Wang commented on PHOENIX-4488:
-------------------------------------

[~jamestaylor]
Pretty straight forward! lgtm.

Q1, Is MetaDataEndPointIT the IT that also covers execeededIndexQuota?
Q2, nit: Patch line 95 (code line 501), trailing whitespaces.

Thanks

> Cache config parameters for MetaDataEndPointImpl during initialization
> ----------------------------------------------------------------------
>
>                 Key: PHOENIX-4488
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4488
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.14.0, 4.13.2
>
>         Attachments: PHOENIX-4488.patch
>
>
> For example, see this code (which is called often):
> {code}
>         boolean blockWriteRebuildIndex = env.getConfiguration().getBoolean(QueryServices.INDEX_FAILURE_BLOCK_WRITE, 
>                 QueryServicesOptions.DEFAULT_INDEX_FAILURE_BLOCK_WRITE);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)