You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2014/03/11 20:00:19 UTC
Review Request 19060: Updated cpplint.py to analyze hpp files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
Bugs: MESOS-1080
https://issues.apache.org/jira/browse/MESOS-1080
Repository: mesos-git
Description
-------
Updated cpplint.py to analyze hpp files.
Diffs
-----
support/cpplint.py a8c9f67
Diff: https://reviews.apache.org/r/19060/diff/
Testing
-------
Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
Thanks,
Adam B
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/#review36830
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19060]
All tests passed.
- Mesos ReviewBot
On March 11, 2014, 7:24 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19060/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 7:24 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1080
> https://issues.apache.org/jira/browse/MESOS-1080
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added hpp files as valid extensions.
>
>
> Diffs
> -----
>
> support/cpplint.py a8c9f67
>
> Diff: https://reviews.apache.org/r/19060/diff/
>
>
> Testing
> -------
>
> Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
> Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/#review38741
-----------------------------------------------------------
Ship it!
Good stuff! I'll get this committed today.
Meanwhile, we should fix the new style errors found in a subsequent review :)
src/master/detector.cpp:117: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp:46: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp:47: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp:50: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp:51: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp:310: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/gate.hpp:50: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/gate.hpp:73: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:84: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:86: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:88: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:90: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:103: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:105: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:107: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:109: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:120: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:123: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:125: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:127: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:129: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:140: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:142: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:144: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:146: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:156: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:157: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:158: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:178: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:179: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:182: Tab found; better to use spaces [whitespace/tab] [1]
3rdparty/libprocess/src/net.hpp:184: Tab found; better to use spaces [whitespace/tab] [1]
- Niklas Nielsen
On March 25, 2014, 5:03 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19060/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 5:03 p.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1080
> https://issues.apache.org/jira/browse/MESOS-1080
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added hpp files as valid extensions.
>
>
> Diffs
> -----
>
> support/cpplint.patch PRE-CREATION
> support/cpplint.py a8c9f67
>
> Diff: https://reviews.apache.org/r/19060/diff/
>
>
> Testing
> -------
>
> Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
> Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/#review38580
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19060]
All tests passed.
- Mesos ReviewBot
On March 26, 2014, 12:03 a.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19060/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 12:03 a.m.)
>
>
> Review request for mesos and Niklas Nielsen.
>
>
> Bugs: MESOS-1080
> https://issues.apache.org/jira/browse/MESOS-1080
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added hpp files as valid extensions.
>
>
> Diffs
> -----
>
> support/cpplint.patch PRE-CREATION
> support/cpplint.py a8c9f67
>
> Diff: https://reviews.apache.org/r/19060/diff/
>
>
> Testing
> -------
>
> Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
> Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/
-----------------------------------------------------------
(Updated March 25, 2014, 5:03 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
I will go ahead and shepherd this RR.
-- Niklas
Bugs: MESOS-1080
https://issues.apache.org/jira/browse/MESOS-1080
Repository: mesos-git
Description
-------
Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added hpp files as valid extensions.
Diffs
-----
support/cpplint.patch PRE-CREATION
support/cpplint.py a8c9f67
Diff: https://reviews.apache.org/r/19060/diff/
Testing
-------
Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
Thanks,
Adam B
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/
-----------------------------------------------------------
(Updated March 25, 2014, 1:33 p.m.)
Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
Changes
-------
Oops, forgot to include hpp changes in actual cpplint.py in diff 4.
Updated with diff 5, where cpplint.py is already patched for hpp's and ready to lint them out of the box (no patch/make step required).
Bugs: MESOS-1080
https://issues.apache.org/jira/browse/MESOS-1080
Repository: mesos-git
Description
-------
Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added hpp files as valid extensions.
Diffs (updated)
-----
support/cpplint.patch PRE-CREATION
support/cpplint.py a8c9f67
Diff: https://reviews.apache.org/r/19060/diff/
Testing
-------
Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
Thanks,
Adam B
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/#review37345
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19060]
All tests passed.
- Mesos ReviewBot
On March 14, 2014, 10:14 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19060/
> -----------------------------------------------------------
>
> (Updated March 14, 2014, 10:14 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1080
> https://issues.apache.org/jira/browse/MESOS-1080
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added hpp files as valid extensions.
>
>
> Diffs
> -----
>
> support/cpplint.patch PRE-CREATION
> support/cpplint.py a8c9f67
>
> Diff: https://reviews.apache.org/r/19060/diff/
>
>
> Testing
> -------
>
> Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
> Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/
-----------------------------------------------------------
(Updated March 14, 2014, 3:14 p.m.)
Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
Changes
-------
Created cpplint.patch to be applied to future updates to cpplint.py from google.
Added a brief comment about what mesos-specific changes are included in my patch.
Left the hpp changes in cpplint.py, so new clones will not need to run a make command before running cpplint/mesos-style.
ReviewBoard still ignores my chmod changes from the diff:
diff --git a/support/mesos-style.py b/support/mesos-style.py
old mode 100644
new mode 100755
This may need to be applied manually by the committer?
Bugs: MESOS-1080
https://issues.apache.org/jira/browse/MESOS-1080
Repository: mesos-git
Description
-------
Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added hpp files as valid extensions.
Diffs (updated)
-----
support/cpplint.patch PRE-CREATION
support/cpplint.py a8c9f67
Diff: https://reviews.apache.org/r/19060/diff/
Testing
-------
Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
Thanks,
Adam B
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Adam B <ad...@mesosphere.io>.
> On March 11, 2014, 6:10 p.m., Bernd Mathiske wrote:
> > How about adding a patch file to be applied (by the build process) to the original ccplint.py as opposed to making inline changes in it? This way we can integrated new versions of cpplint.py and still keep our changes vs. their changes apart with more ease. For reference, this approach has already been exercised in case of
> > ./3rdparty/leveldb.patch
> > ./3rdparty/libprocess/3rdparty/glog-0.3.3.patch
> > ./3rdparty/libprocess/3rdparty/libev-4.15.patch
> > ./m4/python.m4.patch
> >
> > Not sure where the patch-treated cpplint.py should show up. Maybe somewhere in ./build/3rdparty/?
> >
>
> Niklas Nielsen wrote:
> +1, try to take a look in 3rdparty/Makefile.am:54-60 :)
The stamp/patch target in 3rdparty/Makefile.am (and 3rdparty/libprocess/3rdparty/Makefile.am) applies specifically to unzipping, patching, and building tar.gz files for 3rdparty projects, so it makes sense to handle the patching in the Makefile for these cases.
m4/python.m4, however, is just a script/macro, so it needs no make/build process itself. As such, the python.m4.patch that sits alongside python.m4 is already applied to python.m4 in the repo, and the patch sits alongside it to be applied manually after any updates to python.m4.
Since cpplint.py is also just a script, it should not require a make for the patch changes to be applied. A user/dev should be able to clone the mesos git repo and immediately run cpplint.py/mesos-style.py without running 'make' first. Hence, I am following the python.m4 model and checking in the patched version of cpplint.py along with the patch alongside it for reference.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/#review36883
-----------------------------------------------------------
On March 14, 2014, 3:14 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19060/
> -----------------------------------------------------------
>
> (Updated March 14, 2014, 3:14 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1080
> https://issues.apache.org/jira/browse/MESOS-1080
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added hpp files as valid extensions.
>
>
> Diffs
> -----
>
> support/cpplint.patch PRE-CREATION
> support/cpplint.py a8c9f67
>
> Diff: https://reviews.apache.org/r/19060/diff/
>
>
> Testing
> -------
>
> Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
> Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On March 11, 2014, 6:10 p.m., Bernd Mathiske wrote:
> > How about adding a patch file to be applied (by the build process) to the original ccplint.py as opposed to making inline changes in it? This way we can integrated new versions of cpplint.py and still keep our changes vs. their changes apart with more ease. For reference, this approach has already been exercised in case of
> > ./3rdparty/leveldb.patch
> > ./3rdparty/libprocess/3rdparty/glog-0.3.3.patch
> > ./3rdparty/libprocess/3rdparty/libev-4.15.patch
> > ./m4/python.m4.patch
> >
> > Not sure where the patch-treated cpplint.py should show up. Maybe somewhere in ./build/3rdparty/?
> >
+1, try to take a look in 3rdparty/Makefile.am:54-60 :)
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/#review36883
-----------------------------------------------------------
On March 11, 2014, 12:24 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19060/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 12:24 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1080
> https://issues.apache.org/jira/browse/MESOS-1080
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added hpp files as valid extensions.
>
>
> Diffs
> -----
>
> support/cpplint.py a8c9f67
>
> Diff: https://reviews.apache.org/r/19060/diff/
>
>
> Testing
> -------
>
> Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
> Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/#review36883
-----------------------------------------------------------
How about adding a patch file to be applied (by the build process) to the original ccplint.py as opposed to making inline changes in it? This way we can integrated new versions of cpplint.py and still keep our changes vs. their changes apart with more ease. For reference, this approach has already been exercised in case of
./3rdparty/leveldb.patch
./3rdparty/libprocess/3rdparty/glog-0.3.3.patch
./3rdparty/libprocess/3rdparty/libev-4.15.patch
./m4/python.m4.patch
Not sure where the patch-treated cpplint.py should show up. Maybe somewhere in ./build/3rdparty/?
- Bernd Mathiske
On March 11, 2014, 12:24 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19060/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 12:24 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1080
> https://issues.apache.org/jira/browse/MESOS-1080
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added hpp files as valid extensions.
>
>
> Diffs
> -----
>
> support/cpplint.py a8c9f67
>
> Diff: https://reviews.apache.org/r/19060/diff/
>
>
> Testing
> -------
>
> Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
> Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/#review36835
-----------------------------------------------------------
I also did chmod a+x for support/mesos-style.py, and it showed up in the diff file I uploaded, but not in the one downloaded from RB. Anybody know how to make that work? Do we just need to get a committer to make that change manually?
- Adam B
On March 11, 2014, 12:24 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19060/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 12:24 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1080
> https://issues.apache.org/jira/browse/MESOS-1080
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added hpp files as valid extensions.
>
>
> Diffs
> -----
>
> support/cpplint.py a8c9f67
>
> Diff: https://reviews.apache.org/r/19060/diff/
>
>
> Testing
> -------
>
> Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
> Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/
-----------------------------------------------------------
(Updated March 11, 2014, 12:24 p.m.)
Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
Changes
-------
Updated cpplint.py to analyze hpp files
Bugs: MESOS-1080
https://issues.apache.org/jira/browse/MESOS-1080
Repository: mesos-git
Description (updated)
-------
Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added hpp files as valid extensions.
Diffs (updated)
-----
support/cpplint.py a8c9f67
Diff: https://reviews.apache.org/r/19060/diff/
Testing
-------
Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
Thanks,
Adam B
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/
-----------------------------------------------------------
(Updated March 11, 2014, 12:15 p.m.)
Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
Bugs: MESOS-1080
https://issues.apache.org/jira/browse/MESOS-1080
Repository: mesos-git
Description (updated)
-------
Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py.
Adding hpp files to valid extensions in next revision.
Diffs (updated)
-----
support/cpplint.py a8c9f67
Diff: https://reviews.apache.org/r/19060/diff/
Testing
-------
Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
Thanks,
Adam B
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Adam B <ad...@mesosphere.io>.
> On March 11, 2014, 12:05 p.m., Dominic Hamon wrote:
> > support/cpplint.py, line 3573
> > <https://reviews.apache.org/r/19060/diff/1/?file=516611#file516611line3573>
> >
> > we should also start putting test sources alongside the sources they test if we want this method to do anything useful.
Fair enough. Removed the comment.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/#review36826
-----------------------------------------------------------
On March 11, 2014, 12:24 p.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19060/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 12:24 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1080
> https://issues.apache.org/jira/browse/MESOS-1080
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated cpplint.py from https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py and added hpp files as valid extensions.
>
>
> Diffs
> -----
>
> support/cpplint.py a8c9f67
>
> Diff: https://reviews.apache.org/r/19060/diff/
>
>
> Testing
> -------
>
> Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
> Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
>
>
> Thanks,
>
> Adam B
>
>
Re: Review Request 19060: Updated cpplint.py to analyze hpp files.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19060/#review36826
-----------------------------------------------------------
support/cpplint.py
<https://reviews.apache.org/r/19060/#comment68013>
we should also start putting test sources alongside the sources they test if we want this method to do anything useful.
- Dominic Hamon
On March 11, 2014, noon, Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19060/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, noon)
>
>
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Niklas Nielsen.
>
>
> Bugs: MESOS-1080
> https://issues.apache.org/jira/browse/MESOS-1080
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated cpplint.py to analyze hpp files.
>
>
> Diffs
> -----
>
> support/cpplint.py a8c9f67
>
> Diff: https://reviews.apache.org/r/19060/diff/
>
>
> Testing
> -------
>
> Ran cpplint.py with all rules enabled on some of my recent changes; found style errors in hpp headers.
> Ran mesos-style.py on all of mesos source. Found tabs in some libprocess/stout headers.
>
>
> Thanks,
>
> Adam B
>
>