You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/02/17 11:24:31 UTC
[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1243:
js: add session connection
jorgebay commented on a change in pull request #1243: js: add session connection
URL: https://github.com/apache/tinkerpop/pull/1243#discussion_r380117937
##########
File path: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
##########
@@ -95,11 +95,15 @@ class Connection extends EventEmitter {
this.isOpen = false;
this.traversalSource = options.traversalSource || 'g';
this._authenticator = options.authenticator;
+ this._session = options.session || false;
Review comment:
We should add `options.session` to the `Connection` and to the `Client` jsdoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services