[GitHub] [tinkerpop] xiazcy commented on a diff in pull request #1788: Dev Environments: Dockerize Testing for JavaScript and .NET & Updates for Go

[GitBox <gi...@apache.org>]

xiazcy commented on code in PR #1788:
URL: https://github.com/apache/tinkerpop/pull/1788#discussion_r955302711


##########
.github/workflows/build-test.yml:
##########
@@ -141,20 +174,41 @@ jobs:
   javascript:
     name: javascript
     timeout-minutes: 15
-    needs: smoke
+    needs: cache-gremlin-server-docker-image
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ubuntu-latest, windows-latest]
+        # Windows Disabled until Linux containers are supported on Windows runners: https://github.com/actions/virtual-environments/issues/252

Review Comment:
   Thank you Florian! 
   Yes, it was unfortunate that they didn't support this. I think adding another CI provider may be too extensive for now.  Creating a Gremlin Server Windows container could be the easier change if GHA doesn't fix it soon. But definitely agree that having Windows GHA back on in the future would be good. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org